zig: remove JSValue.isEmpty - #15128
Merged
Merged
Conversation
Collaborator
|
❌ @nektro, your commit 905f3b6 has 4 failures in test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🍎 aarch64test/js/web/fetch/fetch-preconnect.test.ts - 1 failing on 🍎 aarch64test/js/node/test/parallel/zlib.test.js - 1 failing on 🍎 aarch64test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 aarch64 |
nektro
marked this pull request as ready for review
November 13, 2024 10:00
dylan-conway
approved these changes
Nov 14, 2024
snoglobe
pushed a commit
that referenced
this pull request
Nov 18, 2024
snoglobe
pushed a commit
that referenced
this pull request
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
progress towards zig JSValue stability and safety
making these direct comparisons to
.zeromakes it clearer to the reader what we're dealing withand eases the transition to remove
.zerolater