rid nearly all use of ExceptionRef in zig - #15100
Merged
Merged
Conversation
Collaborator
|
❌ @nektro, your commit 20fc424 has 3 failures in test/js/bun/http/serve.test.ts - 1 failing on 🍎 x64test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🍎 aarch64test/cli/run/require-cache.test.ts - 1 failing on 🪟 x64 |
nektro
marked this pull request as ready for review
November 12, 2024 08:52
| if (!globalObject.hasException() and exception != null) { | ||
| globalObject.throwValue(exception.?.value()); | ||
| } | ||
| const handlers = Handlers.fromJS(globalObject, socket_obj) catch return .zero; |
dylan-conway
requested changes
Nov 12, 2024
dylan-conway
left a comment
dylan-conway
left a comment
Member
There was a problem hiding this comment.
Looks great. I left a few suggestions. Important ones are in options.zig
dylan-conway
approved these changes
Nov 13, 2024
snoglobe
pushed a commit
that referenced
this pull request
Nov 18, 2024
Co-authored-by: nektro <nektro@users.noreply.github.com>
snoglobe
pushed a commit
that referenced
this pull request
Nov 21, 2024
Co-authored-by: nektro <nektro@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
progress towards zig JSValue stability and safety in #159
many followups to come