Remove unneccessary NULL check in srs_freep. v5.0.150, v6.0.38

[yashwardhan-jyani]

Removed the unnecessary NULL pointer checks in trunk/src/core/srs_core.hpp

https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null

This is my first Pull Request, So if anything's wrong please tell me

[elfring]

The commit message can be improved.

• How do you think about to omit hyphens from the subject?
• Would you like to refer to a previous suggestion in your change description?

[winlinvip]

Seems make sense to me, however I wonder if all compiler check the null pointer?

[elfring]

..., however I wonder if all compilers check the null pointer?

💭 Would you like to support any compiler versions which would be standard-incompliant in this technical detail?

TRANS_BY_GPT3

[xiaozhihong]

@yashwardhan-jyani

Thanks for your PR.

Follow the reference, delete nullptr is safe.
https://cplusplus.com/reference/new/operator%20delete/

https://en.cppreference.com/w/cpp/memory/new/operator_delete

And I test it with simple code.

#include <iostream>

int main()
{
    char* p = NULL;
    delete p;

    return 0;
}

It works well.

Then I gdb the program and find the implement of delete in gcc.

Obvious, operator delete call std::free, std::free call libc free directly, and man 3 free tell us

But I still have a question, in other platforms which not use gcc, for example, MSVC of Windows, cause the same result? Can you test it? Thanks.

[elfring]

But I still have a question, ..., cause the same result?

How much do you care for standard compliance of applied compiler variants? 🤔

TRANS_BY_GPT3

[yashwardhan-jyani]

@xiaozhihong

I tried this on MSVC compiler and it's working fine.

Ignore the errors, it's the intelliSense, i tried to get rid of them but can't seem to do so.