🐛 trip surrounding quotes that may have been added by extractCommand #4736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fixedpoint <[email protected]>
Fix3dP0int
requested review from
justaugustus and
spencerschrock
and removed request for
a team
Fix3dP0int
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4736 +/- ##
==========================================
+ Coverage 66.80% 68.30% +1.50%
==========================================
Files 230 249 +19
Lines 16602 18904 +2302
==========================================
+ Hits 11091 12913 +1822
- Misses 4808 5131 +323
- Partials 703 860 +157 🚀 New features to boost your workflow:
|
|
This pull request has been marked stale because it has been open for 10 days with no activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
URLs surrounded by single quotes ('https://example.com') are properly detected
URLs surrounded by double quotes ("https://example.com") are properly detected
URLs without quotes continue to work as before
Proper pinning validation now works for all quote styles
Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
Fixes #4733
Special notes for your reviewer
Does this PR introduce a user-facing change?
No.
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)