Disable permissions change #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Can you please adapt it to the existing formatting :
Will merge that in the 1.2.3 coming release. |
|
@eduardosan Could you please fix the formatting, so we could all benefit from your fix :) |
|
Hello, The fix is provided in above commit. |
kumy
reviewed
Mar 21, 2019
| @@ -125,7 +127,8 @@ EOF | |||
| mv /tmp/schema/cn=config/cn=schema/* /etc/ldap/slapd.d/cn=config/cn=schema | |||
| rm -r /tmp/schema | |||
|
|
|||
| chown -R openldap:openldap /etc/ldap/slapd.d/cn=config/cn=schema | |||
| if [ -z "$DISABLE_CHOWN" ]; then | |||
| chown -R openldap:openldap /etc/ldap/slapd.d/cn=config/cn=schema | |||
| chown -R openldap:openldap ${CONTAINER_SERVICE_DIR}/slapd | ||
| if [ -z "$DISABLE_CHOWN" ]; then | ||
| chmod 600 ${LDAP_TLS_DH_PARAM_PATH} | ||
| chown -R openldap:openldap ${CONTAINER_SERVICE_DIR}/slapd |
| chown openldap:openldap $PREVIOUS_LDAP_TLS_CRT_PATH $PREVIOUS_LDAP_TLS_KEY_PATH $PREVIOUS_LDAP_TLS_CA_CRT_PATH $PREVIOUS_LDAP_TLS_DH_PARAM_PATH | ||
| if [ -z "$DISABLE_CHOWN" ]; then | ||
| chmod 600 ${PREVIOUS_LDAP_TLS_DH_PARAM_PATH} | ||
| chown openldap:openldap $PREVIOUS_LDAP_TLS_CRT_PATH $PREVIOUS_LDAP_TLS_KEY_PATH $PREVIOUS_LDAP_TLS_CA_CRT_PATH $PREVIOUS_LDAP_TLS_DH_PARAM_PATH |
|
Now I thing they are all included |
|
@eduardosan Thanks 👍 @BertrandGouny Do you think it can be merged? Thanks. |
BertrandGouny
added a commit
that referenced
this pull request
Jul 7, 2019
|
Thanks all, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have a very specific use case where data volumes are mounted from a sshfs partition and other network partitions, and in this case one can't change permissions on remote disks.
I just added an environment var to disable this when it's necessary.