Add request metadata to context (try #2)#42
Merged
osamingo merged 2 commits intoosamingo:masterfrom Feb 19, 2020
alexus1024:feature/cxt_metadata_try_2
Merged
Add request metadata to context (try #2)#42osamingo merged 2 commits intoosamingo:masterfrom alexus1024:feature/cxt_metadata_try_2
osamingo merged 2 commits intoosamingo:masterfrom
alexus1024:feature/cxt_metadata_try_2
Conversation
osamingo
approved these changes
Feb 19, 2020
Owner
osamingo
left a comment
osamingo
left a comment
There was a problem hiding this comment.
@alexus1024 LGTM! I'll bump up v2.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
See header
WHY
Metadata in context allows params unmarshalling as a general step for processing jsonrpc request
First my try to mege this PR was failed because of some git-and-rebase-related problems. This is second try