This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Typescript refactor #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I converted the plugin to typescript. As you can use js in TS, I'm not sure I see any downside to this. I did have to make a couple tweaks here and there to fix type errors. I also removed the
keysstate variable in the admin/settings/index as it seemed superfluous to me and seems to work fine without it. But, I'm not familiar with React (or Strapi either really), so of course add it back in if need be. Anyways, let me know if you have any questions :)Oh, you'll need to run
yarn buildto ouput thedistfolder after making changes now. And sorry for the double commit below. My file manager didn't merge as I intended.