Fix warnings generated by nightly --release tests and bump MSRV to 1.52.0

.github/workflows/test.yml

@@ -22,7 +22,7 @@ jobs:
           - stable
           - beta
           - nightly
-          - 1.51.0 # MSRV
+          - 1.52.0 # MSRV
         os: 
           - ubuntu-latest
           - macos-latest

README.md

@@ -1,5 +1,5 @@
 # orion
-[![Tests](https://github.com/orion-rs/orion/workflows/Tests/badge.svg)](https://github.com/orion-rs/orion/actions) [![Daily tests](https://github.com/orion-rs/orion/workflows/Daily%20tests/badge.svg)](https://github.com/orion-rs/orion/actions) [![dudect](https://github.com/orion-rs/orion-dudect/workflows/dudect/badge.svg)](https://github.com/orion-rs/orion-dudect/actions)  [![Security Audit](https://github.com/orion-rs/orion/workflows/Security%20Audit/badge.svg)](https://github.com/orion-rs/orion/actions) [![codecov](https://codecov.io/gh/orion-rs/orion/branch/master/graph/badge.svg)](https://codecov.io/gh/orion-rs/orion) [![Documentation](https://docs.rs/orion/badge.svg)](https://docs.rs/orion/) [![Crates.io](https://img.shields.io/crates/v/orion.svg)](https://crates.io/crates/orion) [![Safety Dance](https://img.shields.io/badge/unsafe-forbidden-success.svg)](https://github.com/rust-secure-code/safety-dance/) [![MSRV](https://img.shields.io/badge/MSRV-1.51-informational.svg)](https://img.shields.io/badge/MSRV-1.51-informational) [![Matrix](https://img.shields.io/matrix/orion-rs:matrix.org.svg?logo=matrix)](https://matrix.to/#/#orion-rs:matrix.org)
+[![Tests](https://github.com/orion-rs/orion/workflows/Tests/badge.svg)](https://github.com/orion-rs/orion/actions) [![Daily tests](https://github.com/orion-rs/orion/workflows/Daily%20tests/badge.svg)](https://github.com/orion-rs/orion/actions) [![dudect](https://github.com/orion-rs/orion-dudect/workflows/dudect/badge.svg)](https://github.com/orion-rs/orion-dudect/actions)  [![Security Audit](https://github.com/orion-rs/orion/workflows/Security%20Audit/badge.svg)](https://github.com/orion-rs/orion/actions) [![codecov](https://codecov.io/gh/orion-rs/orion/branch/master/graph/badge.svg)](https://codecov.io/gh/orion-rs/orion) [![Documentation](https://docs.rs/orion/badge.svg)](https://docs.rs/orion/) [![Crates.io](https://img.shields.io/crates/v/orion.svg)](https://crates.io/crates/orion) [![Safety Dance](https://img.shields.io/badge/unsafe-forbidden-success.svg)](https://github.com/rust-secure-code/safety-dance/) [![MSRV](https://img.shields.io/badge/MSRV-1.52-informational.svg)](https://img.shields.io/badge/MSRV-1.52-informational) [![Matrix](https://img.shields.io/matrix/orion-rs:matrix.org.svg?logo=matrix)](https://matrix.to/#/#orion-rs:matrix.org)
 
 ### About
 Orion is a cryptography library written in pure Rust. It aims to provide easy and usable crypto while trying to minimize the use of unsafe code. You can read more about Orion in the [wiki](https://github.com/orion-rs/orion/wiki).

src/hazardous/ecc/mod.rs

@@ -24,10 +24,11 @@
     dead_code,
     non_camel_case_types,
     clippy::unnecessary_cast,
-    clippy::unused_unit
+    clippy::unused_unit,
+    rustdoc::broken_intra_doc_links
 )]
-/// Formally verified  Curve25519 field arithmetic from: https://github.com/mit-plv/fiat-crypto
-/// Last taken at commit: https://github.com/mit-plv/fiat-crypto/commit/626203aec9fcf5617631fb687d719e5e78dac09f
+/// Formally verified  Curve25519 field arithmetic from: <https://github.com/mit-plv/fiat-crypto>
+/// Last taken at commit: <https://github.com/mit-plv/fiat-crypto/commit/626203aec9fcf5617631fb687d719e5e78dac09f>
 mod fiat_curve25519_u64;
 
 /// Diffie-Hellman key exchange over Curve25519 as specified in the [RFC 7748](https://datatracker.ietf.org/doc/html/rfc7748).

src/hazardous/ecc/x25519.rs

@@ -62,6 +62,7 @@
 //! # Ok::<(), orion::errors::UnknownCryptoError>(())
 //! ```
 //! [`PrivateKey::generate()`]: crate::hazardous::ecc::x25519::PrivateKey::generate
+//! [`orion::kex`]: crate::kex
 
 use super::fiat_curve25519_u64;
 use crate::errors::UnknownCryptoError;

src/hazardous/hash/sha2/mod.rs

@@ -715,7 +715,7 @@ mod test_word {
     // On 32-bit platforms, due to the on-by-default #[deny(arithmetic_overflow)]
     // this won't compile because of `(u32::MAX as usize) + 1)`, not the from call.
     fn w32_panic_on_above_from() {
-        WordU32::from((u32::MAX as usize) + 1);
+        let _ = WordU32::from((u32::MAX as usize) + 1);
     }
 
     #[test]

tests/ecc/wycheproof_x25519.rs

@@ -11,6 +11,7 @@ pub(crate) struct WycheproofX25519Tests {
     numberOfTests: u64,
     header: Vec<String>,
     #[serde(skip)]
+    #[allow(dead_code)]
     notes: Vec<String>,
     schema: String,
     testGroups: Vec<X25519TestGroup>,

tests/mod.rs

@@ -67,6 +67,7 @@ pub struct TestCaseReader {
     /// A reader over all lines in a file
     lines: Lines<BufReader<File>>,
     test_case_count: u64,
+    #[allow(dead_code)]
     test_cases_skipped: u64,
     // All fields that define a test case: Eg. Key, Nonce, etc
     // NOTE: They MUST be in correct order from beginning to end.