Improved pull request "Files Changed" experience feedback #163932
-
|
Important You can opt in to the public preview from any pull request via About the new experienceThis refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests. What’s new ?Performance 🚀
UX ✨
Accessibility
What's missing? 🟨As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment! |
Beta Was this translation helpful? Give feedback.
Replies: 2088 comments 717 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
Would be nice to have an indicator in the file-tree, if a file was viewed or not. (The checkbox in the filter already helps) Otherwise I love it |
Beta Was this translation helpful? Give feedback.
-
|
I am sure this was mentioned before, but I don't see it at the top: Going through large PRs with 100s of files, one file at a time is insanely inefficient and the main reason I switch back to the "classic" mode. If this becomes the new default I probably won't use GitHub to do such reviews and will review it locally rather. I understand the desire to reduce browser strain, but can't you do it in batches of 20, 50, 100? One at a time is not an option. |
Beta Was this translation helpful? Give feedback.
-
|
When changing a file name, I cannot see the old file name in the new UI, which makes it difficult to properly review the changes. Old UI
New UI
|
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
As i'm 'j' and 'k' ing through files on a larger PR, it'd be nice if the file tree (in the sidebar) scrolled automatically so I can see in the tree the active file I'm viewing. |
Beta Was this translation helpful? Give feedback.
-
|
To view changes since my last review, I now have to click "Files changed" tab > "All commits" button > "Changes since your last review", when before I could just click "Changes since your last review" straight from the main "Conversation" tab on a PR. This common flow (for me) is harder now. |
Beta Was this translation helpful? Give feedback.
-
|
The single file at a time in PRs with a large amount of files is a terrible idea. I'm on a platform team that does large refactors with repeated changes and being able to quickly scan files is very important. this change would render the PR review UI beyond unusable if I had to click every single file. |
Beta Was this translation helpful? Give feedback.
-
|
brad i agree
…On Thu, Nov 6, 2025, 1:43 PM Brad Litterell ***@***.***> wrote:
I think it's highly context dependent. When the files have only a few
lines changed, but a larger PR where the changes to some files may be
extensive, I find the single file view better.
So, I think the upshot of all this is - let the user decide how they want
to see it - instead of having github decide for the user.
—
Reply to this email directly, view it on GitHub
<#163932 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BZTW2Y3C4IIMSOXGJUFOACD33OJGHAVCNFSM6AAAAACAABXI52VHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTIOBZGQ3TQNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
|
Something is broken with the modal for selecting "specific commits":
(Tested on Google Chrome / Mac OS) |
Beta Was this translation helpful? Give feedback.
-
|
(Tested on Brave / Mac OS) The floating Kapture.2025-11-07.at.16.24.37.mp4It looks like the line number or code row is focusable and intercepts the focus. From a usability point of view, I don't think I would ever select a range of lines and then leave a comment in the middle of the selection, perhaps the button should be anchored and always appear on the last selected line whenever multiple lines are selected. |
Beta Was this translation helpful? Give feedback.
-
|
It seems unusable on larger pull requests. I'm currently looking at a linting change that touched 2000 lines across 439 files, and it just causes Safari to consume 170% CPU and become unresponsive for minutes on end. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
It's very difficult to see unresolved comments. I wanted to go through and add a bunch of suggested changes to a batch but there was little if any visual distinction between resolved and unresolved comments and they were hard to locate in the first place. |
Beta Was this translation helpful? Give feedback.
-
|
Can we please get the "Viewed" checkboxes on the PR File Tree, it would be much easier to visualize files/folders already reviewed |
Beta Was this translation helpful? Give feedback.
-
|
Click the comment button just to left of "Submit Review" button. It has a There are three threads; I'm pretty sure all 3 are already resolved. Press the "Resolve Conversation" button: "Failed to resolve thread". https://github.com/openscad/openscad/pull/6251/files#r2425051653 |
Beta Was this translation helpful? Give feedback.






















I notice that some adjustments have already been made to prevent the "real" submit button from getting pushed off screen, so it seems improvements are underway. Thank you!