Improved pull request "Files Changed" experience feedback #163932
Replies: 2847 comments 1150 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
Our 2991 file PR crashes the page in several different ways, making it impossible to approve the PR with the new PR experience. I had to switch to the classic experience one to approve.
and
|
Beta Was this translation helpful? Give feedback.
-
|
I miss having the Ask Copilot button in file changes. I could attach my files and give a prompt that could do a good PR review. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
In the new experience I can't find |
Beta Was this translation helpful? Give feedback.
-
|
One thing I'd like a lot is for comments and "changes since you last review" to still work after a rebase. Even if the commit hashes are different, if the diff they contains are all the same it shouldn't disrupt the review process. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
discovered a very nasty problem today - after leaving a lot of comments on a large diff, my teammate tells me that many of my comments aren't associated with a particular line even though I definitely left them inline. Possibly related to the fact that there are a total 61 comments on the PR so we're getting a warning that only 40 will render (not all 61 are mine, I think many are from a linting bot we have - but filtering in the files view to just my comments doesn't help). We've found no way to view the comments that actually says which line they are on. IMO github reviews main job is to let us comment on code inline and show the author and other reviewers those comments in context, so this failure is a huge trust-breaker. I tried looking at the PR in the old experience as well and the comments don't show up inline there either. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Are there any plans to add support for slash commands ? They don't seem to work Links: |
Beta Was this translation helpful? Give feedback.
-
|
Please 🥹 I need a shortcut to marks the file currently prominently in view as read/unread 😭 |
Beta Was this translation helpful? Give feedback.
-
|
I'm not sure if I'm part of an A/B test or what, but I'm not a fan of this nearly hidden comment view:
It's way too tiny/hidden in my opinion |
Beta Was this translation helpful? Give feedback.
-
|
Hi, Is it possible to add extend button on the right side similar to what is on left side?
Thank you in advance. |
Beta Was this translation helpful? Give feedback.
-
|
Give me an option to choose whether clicking on a notification should bring me to the conversation or the files changed tab. I am not sure if this preview introduced the change, but around the time it was rolled out some notifications started taking me directly to the files changes tab. I rarely use the files changed tab because it's inferior to the VS Code equivalent and I rarely use the VS code conversation tab because it's inferior to the web version. |
Beta Was this translation helpful? Give feedback.
-
|
I am perpetually astounded how GitHub absolutely fails to have "Jump to Comment" work. In the most popular browser (Chrome) with no extensions installed that could interfere. Or the browser made by Microsoft (Edge). For YEARS. "Classic Experience" was (and is) hit or miss - about 50/50 on whether or not it actually jumped to the comment if the file is marked as "Viewed" or was outdated. Now in the "New Experience" it's even worse - probably only works 25% of the time, if that. Even if the file is uncollapsed and the comment is uncollapsed it still won't jump to it. It's baffling. Literally baffling. How can it be this bad when reviewing PRs is like the Number 3 thing that developers do on GitHub. How was this not something that is on the short list of things to fix in the "New Experience"? How did this ever pass QA for either experience? Is the logic that yall just expect us to exclusively use the VS Code extension? If so why not just retire the web interface instead of creating a new worse version? Good. Gods. Do better. </rant> |
Beta Was this translation helpful? Give feedback.
-
|
"Jump to the comment in the diff" doesn't work if the file is hidden: |
Beta Was this translation helpful? Give feedback.


























Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions