feat: switch filters behavior #331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request switches the filter behavior by inverting the checked state of filter switches and adds Node.js legacy OpenSSL provider options to all npm scripts.
Key Changes:
- Inverted the
isCheckedproperty for all filter switches (orphans, dailies, noter, filelessCites, bad) - Added
NODE_OPTIONS='--openssl-legacy-provider'to all Next.js npm scripts
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| package.json | Adds OpenSSL legacy provider options to Next.js scripts for compatibility |
| components/Tweaks/Filter/FilterPanel.tsx | Inverts the checked state logic for all filter switches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to fix filter toggle logic in the
FilterPanelcomponent and updates thepackage.jsonscripts to address compatibility issues with OpenSSL. The most important changes are grouped below by theme.Filter toggle logic fixes:
isCheckedproperty for multiple switches inFilterPanelto correctly reflect the toggled state by negating the respective filter values (components/Tweaks/Filter/FilterPanel.tsx). [1] [2] [3] [4] [5]Build script updates:
NODE_OPTIONS='--openssl-legacy-provider'to thedev,build,export, andstartscripts inpackage.jsonto ensure compatibility with legacy OpenSSL versions (package.json).