Update jdtls version from 1.42.0-561 to 1.53.0-873#1238
Update jdtls version from 1.42.0-561 to 1.53.0-873#1238stewardc wants to merge 5 commits intooraios:mainfrom
1.42.0-561 to 1.53.0-873#1238Conversation
…ure directory and file is writeable before extracting zip
|
New PR with the SHA checks in place. One thing to note, the workspace config.ini seems to pin the old JDTLS version. I can try to force an update, or leave it as-is (maybe add something to the project readme?) Let me know how you'd like to handle this. Thanks! |
|
Thanks! I think we need to address the follow-up issue (#1232) first, we shouldn't just overwrite the existing version all the time |
Makes sense - I agree, it felt wrong to just blindly overwrite. If it's not urgent, I can take a look at that issue when I've got some spare time over the next couple of weeks. |
|
It's not urgent, but @opcode81 and I need to converge on the most suitable approach before the issue is addressed. Feel free to comment in the issue to participate in the discussion but I'd ask to refer from making a PR until the solution is sufficiently sketched out in the issue |
Summary
This PR updates the bundled Eclipse JDTLS runtime assets and fixes a reinstallation issue when Serena extracts over an existing read-only file.
What changed
vscode_java_versionfrom1.42.0-561to1.53.0-873vscode-javabundle21.0.101.7.100.v20251111-0406Why
The JDTLS runtime references were still pinned to an older
vscode-javarelease. The old version fails when a project contains many layers of mutually recursive generics (run Serena against https://github.com/stewardc/mutuallyRecursiveGenericsDemo to see the error). Updating the version resolves this issue.The extraction fix addresses a practical upgrade path issue: if Serena reuses an existing install directory and encounters a read-only file, extraction can fail instead of refreshing the bundle.
Testing