Skip to content

[GR-68052] Avoid building librubyvm in ruby-lint CI job #3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

[GR-68052] Avoid building librubyvm in ruby-lint CI job #3930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
767a185
Run spotbugs with --primary
eregon Jul 29, 2025
7060009
Run ruby-lint with jdk-latest to avoid building librubyvm
eregon Jul 29, 2025
7204517
Make ruby-lint tier1 as it should be fast enough now
eregon Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,8 +537,7 @@ local composition_environment = utils.add_inclusion_tracking(part_definitions, "

test_builds:
{
# Lint runs on JDK stable because some lint tools do not work on JDK latest
"ruby-lint": $.platform.linux + $.cap.tier2 + $.jdk.stable + $.use.common + $.env.jvm + $.use.build + $.run.lint + { timelimit: "45:00" },
"ruby-lint": $.platform.linux + $.cap.tier1 + $.jdk.latest + $.use.common + $.env.jvm + $.use.build + $.run.lint + { timelimit: "45:00" },
# Run specs on CRuby to make sure new specs are compatible and have the needed version guards
"ruby-test-specs-on-cruby": $.platform.linux + $.cap.tier2 + $.use.skip_ci + $.use.common + $.run.test_specs_mri + { timelimit: "45:00" },
} +
Expand Down Expand Up @@ -765,6 +764,7 @@ local composition_environment = utils.add_inclusion_tracking(part_definitions, "
specVersion: "7",
overlay: overlay,
tierConfig: {
"tier1": "gate",
"tier2": "gate",
"tier3": "gate",
},
Expand Down
2 changes: 1 addition & 1 deletion mx.truffleruby/mx_truffleruby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ def ruby_spotbugs(args):
spotbugsArgs = ['-textui', '-low', '-longBugCodes', '-include', filters]
if mx.is_interactive():
spotbugsArgs.append('-progress')
sys.exit(mx_spotbugs.spotbugs(args, spotbugsArgs))
sys.exit(mx_spotbugs.spotbugs(['--primary', *args], spotbugsArgs))

def verify_ci(args):
"""Verify CI configuration"""
Expand Down