Tests of v8::Object::CreateDataProperty().

Author: iamstolis

graal-nodejs/test/graal/unit/object.cc

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -254,4 +254,28 @@ EXPORT_TO_JS(SetIntegrityLevel) {
     }
 }
 
+EXPORT_TO_JS(CreateDataProperty) {
+    Local<Context> context = args.GetIsolate()->GetCurrentContext();
+    Local<Object> obj = args[0].As<Object>();
+    Local<Name> key = args[1].As<Name>();
+
+    Maybe<bool> result = obj->CreateDataProperty(context, key, args[2]);
+
+    if (result.IsJust()) {
+        args.GetReturnValue().Set(result.FromJust());
+    }
+}
+
+EXPORT_TO_JS(CreateDataPropertyIndex) {
+    Local<Context> context = args.GetIsolate()->GetCurrentContext();
+    Local<Object> obj = args[0].As<Object>();
+    uint32_t index = args[1]->Uint32Value(context).FromJust();
+
+    Maybe<bool> result = obj->CreateDataProperty(context, index, args[2]);
+
+    if (result.IsJust()) {
+        args.GetReturnValue().Set(result.FromJust());
+    }
+}
+
 #undef SUITE

graal-nodejs/test/graal/unit/object.js

@@ -507,4 +507,74 @@ describe('Object', function () {
             });
         }
     });
+    describe('CreateDataProperty', function () {
+        describe('name version', function () {
+            it('should create data property', function () {
+                var o = {};
+                var key = 'foo';
+                assert.strictEqual(module.Object_CreateDataProperty(o, key, 42), true);
+                var desc = Object.getOwnPropertyDescriptor(o, key);
+                assert.strictEqual(desc.value, 42);
+                assert.strictEqual(desc.configurable, true);
+                assert.strictEqual(desc.enumerable, true);
+                assert.strictEqual(desc.writable, true);
+            });
+            it('should not override existing non-configurable property', function () {
+                var o = {};
+                var key = 'foo';
+                Object.defineProperty(o, key, { value: 211 });
+                assert.strictEqual(module.Object_CreateDataProperty(o, key, 42), false);
+                var desc = Object.getOwnPropertyDescriptor(o, key);
+                assert.strictEqual(desc.value, 211);
+                assert.strictEqual(desc.configurable, false);
+                assert.strictEqual(desc.enumerable, false);
+                assert.strictEqual(desc.writable, false);
+            });
+            it('should not create data property on non-extensible object', function () {
+                var o = Object.freeze({});
+                var key = 'foo';
+                assert.strictEqual(module.Object_CreateDataProperty(o, key, 42), false);
+                assert.strictEqual(Object.getOwnPropertyDescriptor(o, key), undefined);
+            });
+        });
+        describe('index version', function () {
+            it('should create data property', function () {
+                var o = {};
+                var key = 123;
+                assert.strictEqual(module.Object_CreateDataPropertyIndex(o, key, 42), true);
+                var desc = Object.getOwnPropertyDescriptor(o, key);
+                assert.strictEqual(desc.value, 42);
+                assert.strictEqual(desc.configurable, true);
+                assert.strictEqual(desc.enumerable, true);
+                assert.strictEqual(desc.writable, true);
+            });
+            it('should not override existing non-configurable property', function () {
+                var o = {};
+                var key = 123;
+                Object.defineProperty(o, key, { value: 211 });
+                assert.strictEqual(module.Object_CreateDataPropertyIndex(o, key, 42), false);
+                var desc = Object.getOwnPropertyDescriptor(o, key);
+                assert.strictEqual(desc.value, 211);
+                assert.strictEqual(desc.configurable, false);
+                assert.strictEqual(desc.enumerable, false);
+                assert.strictEqual(desc.writable, false);
+            });
+            it('should not create data property on non-extensible object', function () {
+                var o = Object.freeze({});
+                var key = 123;
+                assert.strictEqual(module.Object_CreateDataPropertyIndex(o, key, 42), false);
+                assert.strictEqual(Object.getOwnPropertyDescriptor(o, key), undefined);
+            });
+            it('should work for indices that do not fit into int32', function () {
+                var o = {};
+                var key = 4294967295;
+                assert.strictEqual(module.Object_CreateDataPropertyIndex(o, key, 42), true);
+                var desc = Object.getOwnPropertyDescriptor(o, key);
+                assert.strictEqual(desc.value, 42);
+                assert.strictEqual(desc.configurable, true);
+                assert.strictEqual(desc.enumerable, true);
+                assert.strictEqual(desc.writable, true);
+            });
+        });
+    });
 });