Implementation of v8::Object::CreateDataProperty().

Author: iamstolis

graal-nodejs/deps/v8/src/graal/graal_isolate.cc

@@ -642,6 +642,8 @@ GraalIsolate::GraalIsolate(JavaVM* jvm, JNIEnv* env, v8::Isolate::CreateParams c
     ACCESS_METHOD(GraalAccessMethod::object_get_property_names, "objectGetPropertyNames", "(Ljava/lang/Object;ZZZZZZZZ)Ljava/lang/Object;")
     ACCESS_METHOD(GraalAccessMethod::object_get_own_property_names, "objectGetOwnPropertyNames", "(Ljava/lang/Object;)Ljava/lang/Object;")
     ACCESS_METHOD(GraalAccessMethod::object_creation_context, "objectCreationContext", "(Ljava/lang/Object;)Ljava/lang/Object;")
+    ACCESS_METHOD(GraalAccessMethod::object_create_data_property, "objectCreateDataProperty", "(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)Z")
+    ACCESS_METHOD(GraalAccessMethod::object_create_data_property_index, "objectCreateDataProperty", "(Ljava/lang/Object;JLjava/lang/Object;)Z")
     ACCESS_METHOD(GraalAccessMethod::object_define_property, "objectDefineProperty", "(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;ZZZZZZ)Z")
     ACCESS_METHOD(GraalAccessMethod::object_preview_entries, "objectPreviewEntries", "(Ljava/lang/Object;)Ljava/lang/Object;")
     ACCESS_METHOD(GraalAccessMethod::object_set_integrity_level, "objectSetIntegrityLevel", "(Ljava/lang/Object;Z)V")

graal-nodejs/deps/v8/src/graal/graal_isolate.h

@@ -157,6 +157,8 @@ enum GraalAccessMethod {
     object_get_property_names,
     object_get_own_property_names,
     object_creation_context,
+    object_create_data_property,
+    object_create_data_property_index,
     object_define_property,
     object_preview_entries,
     object_set_integrity_level,

graal-nodejs/deps/v8/src/graal/graal_object.cc

@@ -299,6 +299,20 @@ v8::MaybeLocal<v8::Value> GraalObject::GetOwnPropertyDescriptor(v8::Local<v8::Co
     return v8_result;
 }
 
+v8::Maybe<bool> GraalObject::CreateDataProperty(v8::Local<v8::Context> context, v8::Local<v8::Name> key, v8::Local<v8::Value> value) {
+    jobject java_key = reinterpret_cast<GraalHandleContent*> (*key)->GetJavaObject();
+    jobject java_value = reinterpret_cast<GraalHandleContent*> (*value)->GetJavaObject();
+    JNI_CALL(jboolean, result, Isolate(), GraalAccessMethod::object_create_data_property, Boolean, GetJavaObject(), java_key, java_value);
+    return v8::Just((bool) result);
+}
+
+v8::Maybe<bool> GraalObject::CreateDataProperty(v8::Local<v8::Context> context, uint32_t index, v8::Local<v8::Value> value) {
+    jlong java_index = (jlong) index;
+    jobject java_value = reinterpret_cast<GraalHandleContent*> (*value)->GetJavaObject();
+    JNI_CALL(jboolean, result, Isolate(), GraalAccessMethod::object_create_data_property_index, Boolean, GetJavaObject(), java_index, java_value);
+    return v8::Just((bool) result);
+}
+
 v8::Maybe<bool> GraalObject::DefineProperty(v8::Local<v8::Context> context, v8::Local<v8::Name> key, v8::PropertyDescriptor& descriptor) {
     jobject java_key = reinterpret_cast<GraalHandleContent*> (*key)->GetJavaObject();
     jobject value = descriptor.has_value() ? reinterpret_cast<GraalHandleContent*> (*descriptor.value())->GetJavaObject() : NULL;

graal-nodejs/deps/v8/src/graal/graal_object.h

@@ -87,6 +87,8 @@ class GraalObject : public GraalValue {
     v8::Maybe<bool> HasPrivate(v8::Local<v8::Context> context, v8::Local<v8::Private> key);
     v8::Maybe<bool> DeletePrivate(v8::Local<v8::Context> context, v8::Local<v8::Private> key);
     v8::MaybeLocal<v8::Value> GetOwnPropertyDescriptor(v8::Local<v8::Context> context, v8::Local<v8::Name> key);
+    v8::Maybe<bool> CreateDataProperty(v8::Local<v8::Context> context, v8::Local<v8::Name> key, v8::Local<v8::Value> value);
+    v8::Maybe<bool> CreateDataProperty(v8::Local<v8::Context> context, uint32_t index, v8::Local<v8::Value> value);
     v8::Maybe<bool> DefineProperty(v8::Local<v8::Context> context, v8::Local<v8::Name> key, v8::PropertyDescriptor& descriptor);
     v8::MaybeLocal<v8::Array> PreviewEntries(bool* is_key_value);
     v8::Maybe<bool> SetIntegrityLevel(v8::Local<v8::Context> context, v8::IntegrityLevel level);

graal-nodejs/deps/v8/src/graal/v8.cc

@@ -1940,6 +1940,14 @@ namespace v8 {
         return Just(GetEndColumn());
     }
 
+    Maybe<bool> Object::CreateDataProperty(Local<Context> context, Local<Name> key, Local<Value> value) {
+        return reinterpret_cast<GraalObject*> (this)->CreateDataProperty(context, key, value);
+    }
+
+    Maybe<bool> Object::CreateDataProperty(Local<Context> context, uint32_t index, Local<Value> value) {
+        return reinterpret_cast<GraalObject*> (this)->CreateDataProperty(context, index, value);
+    }
+
     Maybe<bool> Object::DefineOwnProperty(Local<Context> context, Local<Name> key, Local<Value> value, PropertyAttribute attributes) {
         return Just(reinterpret_cast<GraalObject*> (this)->ForceSet(key, value, attributes));
     }

graal-nodejs/mx.graal-nodejs/com.oracle.truffle.trufflenode/src/com/oracle/truffle/trufflenode/GraalJSAccess.java

@@ -926,6 +926,14 @@ public Object objectGetOwnPropertyDescriptor(Object object, Object key) {
         return JSRuntime.fromPropertyDescriptor(desc, context);
     }
 
+    public boolean objectCreateDataProperty(Object object, Object key, Object value) {
+        return JSRuntime.createDataProperty((JSDynamicObject) object, key, value);
+    }
+
+    public boolean objectCreateDataProperty(Object object, long index, Object value) {
+        return objectCreateDataProperty(object, Strings.fromLong(index), value);
+    }
+
     public boolean objectDefineProperty(Object object, Object key,
                     Object value, Object get, Object set,
                     boolean hasEnumerable, boolean enumerable,

graal-nodejs/mx.graal-nodejs/com.oracle.truffle.trufflenode/src/svmnodejs.jniconfig

@@ -142,6 +142,7 @@
       { "name": "numberNew" },
       { "name": "numberObjectNew" },
       { "name": "objectClone" },
+      { "name": "objectCreateDataProperty" },
       { "name": "objectCreationContext" },
       { "name": "objectDefineProperty" },
       { "name": "objectDelete" },