Add poly_engine_get_languages_size to C API
#4053
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oubidar-Abderrahim
requested review from
christianwimmer
and removed request for
christianwimmer
vjovanov
reviewed
Dec 14, 2021
...src/org.graalvm.polyglot.nativeapi/src/org/graalvm/polyglot/nativeapi/PolyglotNativeAPI.java
Outdated
Show resolved
Hide resolved
Incorporate feedback from @vjovanov review in oracle#4053
|
Updated, requesting a review 👍 (I am not familiar with conventions/rules about formatting of |
vjovanov
reviewed
Jan 27, 2022
| @@ -221,8 +221,24 @@ public static PolyglotStatus poly_engine_close(PolyglotIsolateThread thread, Pol | |||
| } | |||
|
|
|||
| @CEntryPoint(name = "poly_engine_get_languages", documentation = { | |||
| "Returns an array of size returned by {@link poly_engine_get_languages_size} where each element is a <code>poly_language<code> handle.", | |||
There was a problem hiding this comment.
This will end up in the C API. Is @link of relevance there?
There was a problem hiding this comment.
Answering to myself: https://www.doxygen.nl/manual/commands.html
vjovanov
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4052