AArch64: Add MatchRules for bit field operations #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds match rules for AArch64 Unsigned Bit Field Extract
(UBFX) and Unsigned Bit Field Insert in Zero (UBFIZ) operations.
After this change, AArch64 instruction sequence like
lsr w0, w1, #5
and w0, w0, #0xff
could be replaced by
ubfx w0, w1, #5, #8
and instruction sequence like
and w0, w1, #0x3
lsl w0, w0, #16
could be replaced by
ubfiz w0, w1, #16, #2
|
Hi there, anyone could help looking at this patch? |
|
Hi Pengfei, This looks good to me but you'll need an Oracle reviewer to accept and push it. Perhaps Stefan Anziger (@sanzinger) can comment? |
|
Looks good to merge. |
|
Update: I am going to merge this PR today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds match rules for AArch64 Unsigned Bit Field Extract
(UBFX) and Unsigned Bit Field Insert in Zero (UBFIZ) operations.
After this change, AArch64 instruction sequence like
lsr w0, w1, #5
and w0, w0, #0xff
could be replaced by
ubfx w0, w1, #5, #8
and instruction sequence like
and w0, w1, #0x3
lsl w0, w0, #16
could be replaced by
ubfiz w0, w1, #16, #2