Skip to content

[FSSDK-11690] chore: remove layer id from holdout #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025

Conversation

muzahidul-opti
Copy link
Contributor

Summary

  • Since the layer id is not required for HO, it has been removed.

Test plan

  • All existing test cases should be passed

Issues

  • FSSDK-11690

@muzahidul-opti muzahidul-opti marked this pull request as ready for review July 14, 2025 17:37
@muzahidul-opti muzahidul-opti requested a review from jaeopt July 14, 2025 17:38
lhs.variations == rhs.variations &&
lhs.layerId == rhs.layerId &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't remove this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can.

Comment on lines +44 to +45
// Not necessary for HO
var layerId: String = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExperimentCore protocol requires the implementation of layerId. There are two ways: we can either provide a default value via protocol extension or implement layerId explicitly in each confirming type. The second approach is much clearer to me.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muzahidul-opti muzahidul-opti merged commit 6fd56c3 into master Jul 15, 2025
10 of 12 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/remove-layer-id branch July 15, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants