Skip to content

feat(OptimizelyConfig): Add new fields to OptimizelyConfig #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Aug 2, 2021
Merged

feat(OptimizelyConfig): Add new fields to OptimizelyConfig #266

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
98dcba5
Added new Optimizely config fields
mnoman09 Jun 30, 2021
41e684b
Added delivery rules
mnoman09 Jul 2, 2021
c6ad489
Added optimizelyAudience and rollout featureVariables fix
mnoman09 Jul 6, 2021
9973794
Added new line at end
mnoman09 Jul 6, 2021
665c553
Added audiences and fixed tests
mnoman09 Jul 8, 2021
3c04342
Net 3.5 deserializing fix
mnoman09 Jul 9, 2021
1c0bf1a
Used string builder instead of string
mnoman09 Jul 13, 2021
ef6218b
Added OptimizelyProjectConfigTest file in tests
mnoman09 Jul 13, 2021
9fc9d54
Moved getEvent After GetFeaturesMap
mnoman09 Jul 13, 2021
53fbc69
Resolved comments and refactored logic
mnoman09 Jul 15, 2021
c8ccfca
Fixed space was added before NOT condition in audiences
mnoman09 Jul 26, 2021
b85ae86
Resolved comments
mnoman09 Jul 26, 2021
22a2039
Resolved unitTest issue
mnoman09 Jul 26, 2021
9ace97f
removed two additional tests for testing
mnoman09 Jul 27, 2021
621e62c
Merge branch 'master' into mnoman/optimizelyConfigNewFields
mnoman09 Jul 27, 2021
ce2505b
Audience array merge fix Unit test fix
mnoman09 Jul 27, 2021
b362593
Condition simplified
mnoman09 Jul 27, 2021
cb47e3c
Added OptimizelyEvent and OptimizelyAttribute Class
mnoman09 Jul 27, 2021
8ba7fe5
Added $opt_dummy_audience in datafile to verify that it is getting ig…
mnoman09 Jul 28, 2021
62ed97f
Added serializedAudiences Tests cases
mnoman09 Jul 28, 2021
c685c61
refactored little bit.
msohailhussain Jul 29, 2021
7351048
Refactored comments
mnoman09 Jul 29, 2021
f1e684f
added unit tests for multiple experiment and removed sdk and env key.
msohailhussain Jul 29, 2021
b5d3383
Setting sdkKey and environment key default value as empty string
mnoman09 Jul 30, 2021
1e9d40f
fixed sorting issue
msohailhussain Jul 30, 2021
6a8dafa
corrected sequence of audiences
msohailhussain Aug 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions OptimizelySDK.Net35/OptimizelySDK.Net35.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,9 +284,18 @@
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyConfig.cs">
<Link>OptlyConfig\OptimizelyConfig.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyAttribute.cs">
<Link>OptlyConfig\OptimizelyAttribute.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyEvent.cs">
<Link>OptlyConfig\OptimizelyEvent.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyExperiment.cs">
<Link>OptlyConfig\OptimizelyExperiment.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyAudience.cs">
<Link>OptlyConfig\OptimizelyAudience.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyFeature.cs">
<Link>OptlyConfig\OptimizelyFeature.cs</Link>
</Compile>
Expand Down
9 changes: 9 additions & 0 deletions OptimizelySDK.Net40/OptimizelySDK.Net40.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,12 @@
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyConfig.cs">
<Link>OptlyConfig\OptimizelyConfig.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyAttribute.cs">
<Link>OptlyConfig\OptimizelyAttribute.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyEvent.cs">
<Link>OptlyConfig\OptimizelyEvent.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyExperiment.cs">
<Link>OptlyConfig\OptimizelyExperiment.cs</Link>
Expand All @@ -312,6 +318,9 @@
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyVariation.cs">
<Link>OptlyConfig\OptimizelyVariation.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyAudience.cs">
<Link>OptlyConfig\OptimizelyAudience.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyConfigService.cs">
<Link>OptlyConfig\OptimizelyConfigService.cs</Link>
Expand Down
3 changes: 3 additions & 0 deletions OptimizelySDK.NetStandard16/OptimizelySDK.NetStandard16.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,13 @@
<Compile Include="..\OptimizelySDK\Config\PollingProjectConfigManager.cs" />
<Compile Include="..\OptimizelySDK\Config\HttpProjectConfigManager.cs" />
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyConfig.cs" />
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyAttribute.cs" />
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyEvent.cs" />
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyExperiment.cs" />
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyFeature.cs" />
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyVariable.cs" />
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyVariation.cs" />
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyAudience.cs" />
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyConfigService.cs" />
<Compile Include="..\OptimizelySDK\OptlyConfig\IOptimizelyConfigManager.cs" />
<Compile Include="..\OptimizelySDK\OptimizelyDecisions\DecisionMessage.cs" />
Expand Down
9 changes: 9 additions & 0 deletions OptimizelySDK.NetStandard20/OptimizelySDK.NetStandard20.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,15 @@
</Compile>
<Compile Include="..\OptimizelySDK\Event\EventProcessor.cs">
<Link>Event\EventProcessor.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyAttribute.cs">
<Link>OptlyConfig\OptimizelyAttribute.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyConfig.cs">
<Link>OptlyConfig\OptimizelyConfig.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyEvent.cs">
<Link>OptlyConfig\OptimizelyEvent.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyExperiment.cs">
<Link>OptlyConfig\OptimizelyExperiment.cs</Link>
Expand All @@ -270,6 +276,9 @@
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyVariable.cs">
<Link>OptlyConfig\OptimizelyVariable.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyAudience.cs">
<Link>OptlyConfig\OptimizelyAudience.cs</Link>
</Compile>
<Compile Include="..\OptimizelySDK\OptlyConfig\OptimizelyVariation.cs">
<Link>OptlyConfig\OptimizelyVariation.cs</Link>
Expand Down
276 changes: 207 additions & 69 deletions OptimizelySDK.Tests/OptimizelyConfigTests/OptimizelyConfigTest.cs
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions OptimizelySDK.Tests/OptimizelySDK.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
<Compile Include="DecisionServiceTest.cs" />
<Compile Include="DefaultErrorHandlerTest.cs" />
<Compile Include="EventTests\EventProcessorProps.cs" />
<Compile Include="OptimizelyConfigTests\OptimizelyConfigTest.cs" />
<Compile Include="OptimizelyDecisions\OptimizelyDecisionTest.cs" />
<Compile Include="OptimizelyJSONTest.cs" />
<Compile Include="EventTests\BatchEventProcessorTest.cs" />
Expand Down
3 changes: 3 additions & 0 deletions OptimizelySDK/OptimizelySDK.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@
<Compile Include="Optimizely.cs" />
<Compile Include="Bucketing\UserProfile.cs" />
<Compile Include="OptlyConfig\IOptimizelyConfigManager.cs" />
<Compile Include="OptlyConfig\OptimizelyEvent.cs" />
<Compile Include="OptlyConfig\OptimizelyAttribute.cs" />
<Compile Include="OptlyConfig\OptimizelyAudience.cs" />
<Compile Include="OptlyConfig\OptimizelyConfig.cs" />
<Compile Include="OptlyConfig\OptimizelyConfigService.cs" />
<Compile Include="OptlyConfig\OptimizelyExperiment.cs" />
Expand Down
24 changes: 24 additions & 0 deletions OptimizelySDK/OptlyConfig/OptimizelyAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/*
* Copyright 2021, Optimizely
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

using OptimizelySDK.Entity;

namespace OptimizelySDK.OptlyConfig
{
public class OptimizelyAttribute : IdKeyEntity
{
}
}
43 changes: 43 additions & 0 deletions OptimizelySDK/OptlyConfig/OptimizelyAudience.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/*
* Copyright 2021, Optimizely
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

namespace OptimizelySDK.OptlyConfig
{
public class OptimizelyAudience
{
/// <summary>
/// Audience ID
/// </summary>
public string Id { get; set; }

/// <summary>
/// Audience Name
/// </summary>
public string Name { get; set; }

/// <summary>
/// Audience Conditions
/// </summary>
public object Conditions { get; set; }

public OptimizelyAudience(string id, string name, object conditions)
{
Id = id;
Name = name;
Conditions = conditions;
}
}
}
10 changes: 8 additions & 2 deletions OptimizelySDK/OptlyConfig/OptimizelyConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,14 @@ public class OptimizelyConfig
public string SDKKey { get; private set; }
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)]
public string EnvironmentKey { get; private set; }
public OptimizelyEvent[] Events { get; private set; }
public OptimizelyAudience[] Audiences { get; private set; }
public OptimizelyAttribute[] Attributes { get; private set; }
public IDictionary<string, OptimizelyExperiment> ExperimentsMap { get; private set; }
public IDictionary<string, OptimizelyFeature> FeaturesMap { get; private set; }

private string _datafile;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have auto formatted code, we won't have to make these kinds of fixes.

public OptimizelyConfig(string revision, IDictionary<string, OptimizelyExperiment> experimentsMap, IDictionary<string, OptimizelyFeature> featuresMap, string datafile = null)
{
Revision = revision;
Expand All @@ -39,10 +42,13 @@ public OptimizelyConfig(string revision, IDictionary<string, OptimizelyExperimen
_datafile = datafile;
}

public OptimizelyConfig(string revision, string sdkKey, string environmentKey, IDictionary<string, OptimizelyExperiment> experimentsMap, IDictionary<string, OptimizelyFeature> featuresMap, string datafile = null)
public OptimizelyConfig(string revision, string sdkKey, string environmentKey, OptimizelyAttribute[] attributes, OptimizelyAudience[] audiences, OptimizelyEvent[] events, IDictionary<string, OptimizelyExperiment> experimentsMap, IDictionary<string, OptimizelyFeature> featuresMap, string datafile = null)
{
Revision = revision;
SDKKey = sdkKey;
Attributes = attributes;
Audiences = audiences;
Events = events;
EnvironmentKey = environmentKey;
ExperimentsMap = experimentsMap;
FeaturesMap = featuresMap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have these multiple constructors? This is for creating OptimizelyConfig internally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are publicly exposed classes, that's why we added another constructor.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's expected that clients use OptimizelyConfig object, not building it. Consider not exposing constructor to public if can be controlled.

Expand Down
Loading