Flag empty list concatenation #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oppiliappan
requested changes
Jul 10, 2022
Owner
oppiliappan
left a comment
oppiliappan
left a comment
There was a problem hiding this comment.
Thanks for the PR! Apart from minor code changes, there is one more addition: unit tests, please add snapshot data to bin/tests/data and run cargo insta review
Contributor
Author
|
Done, tests included. |
ilkecan
approved these changes
Sep 24, 2022
`[] ++ something` should be reduced to just `something` Simplify the check Add unit tests
oppiliappan
force-pushed
the
empty-list
branch
from
492d6dd to
9d3b0cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[] ++ somethingshould be reduced to justsomething