Skip to content

Catd graphql play #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

grokspawn
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2025
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit c7edbd2
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6879afdc3496720008331cde
😎 Deploy Preview https://deploy-preview-2100--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

openshift-ci bot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 0.54152% with 551 lines in your changes missing coverage. Please review.

Project coverage is 46.34%. Comparing base (e088ce9) to head (9e65b3e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/catalogd/graphql/graphql.go 0.00% 471 Missing ⚠️
internal/catalogd/storage/localdir.go 3.61% 79 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (e088ce9) and HEAD (9e65b3e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e088ce9) HEAD (9e65b3e)
unit 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2100       +/-   ##
===========================================
- Coverage   73.54%   46.34%   -27.21%     
===========================================
  Files          78       74        -4     
  Lines        7240     7151       -89     
===========================================
- Hits         5325     3314     -2011     
- Misses       1564     3381     +1817     
- Partials      351      456      +105     
Flag Coverage Δ
e2e 40.49% <0.54%> (-3.65%) ⬇️
experimental-e2e 46.21% <0.54%> (-3.84%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant