🌱 Remove test-operator.v2.0.0 fixture #2093
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2093 +/- ##
==========================================
+ Coverage 73.60% 73.65% +0.04%
==========================================
Files 78 78
Lines 7260 7260
==========================================
+ Hits 5344 5347 +3
+ Misses 1566 1564 -2
+ Partials 350 349 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
refactor-e2e-fixtures
branch
from
c84160a to
27cb275
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit 8cf5bda
into
operator-framework:main
Description
Removes the test-operator v2.0.0 fixture and uses the v1.0.0 fixture instead.
Renames test-operator.v2.0.0 to v1.3.0 in the v2 catalog and updates the e2e test accordingly.
Moves the v2.0.0 configmap into the v1.0.0 bundle and updates the e2e test accordingly.
Motivation: the only difference between v1.0.0 and v2.0.0 is that the configmap in v2.0.0 has a different annotation. There are no breaking API changes or anything. Once we move to a more fleshed out test-operator, v2.0.0 will have breaking changes and webhooks (at least for conversion). Since webhooks are not GA yet, this also presents a some issues since we cannot such a v2 in the current e2es.
Reviewer Checklist