Skip to content

🐛 Run bingo get #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Feb 18, 2025

Normally bingo get doesn't make changes, but this is leaving stuff around.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Normally bingo get doesn't make changes, but this is leaving stuff around.

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort requested a review from a team as a code owner February 18, 2025 21:58
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit f94844f
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67b5028bfc49050008204f7a
😎 Deploy Preview https://deploy-preview-1792--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshort tmshort enabled auto-merge February 18, 2025 22:08
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.32%. Comparing base (17220c2) to head (f94844f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
- Coverage   68.39%   68.32%   -0.08%     
==========================================
  Files          63       63              
  Lines        5117     5117              
==========================================
- Hits         3500     3496       -4     
- Misses       1388     1391       +3     
- Partials      229      230       +1     
Flag Coverage Δ
e2e 51.70% <ø> (-0.08%) ⬇️
unit 55.89% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort tmshort added this pull request to the merge queue Feb 18, 2025
Merged via the queue into operator-framework:main with commit dd4d61f Feb 18, 2025
20 of 21 checks passed
@@ -2,6 +2,4 @@ module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT

go 1.23.0

toolchain go1.22.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tmshort tmshort deleted the remove-toolchain branch February 25, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants