🐛 fix bingo-upgrade target #1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Per Goncalves da Silva <[email protected]>
perdasilva
force-pushed
the
fix/bingo-upgrade
branch
from
6423f35 to
1f0a7aa
Compare
azych
approved these changes
Jan 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1609 +/- ##
==========================================
- Coverage 75.64% 66.68% -8.96%
==========================================
Files 42 57 +15
Lines 3326 4584 +1258
==========================================
+ Hits 2516 3057 +541
- Misses 638 1302 +664
- Partials 172 225 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @for pkg in $$($(BINGO) list | awk '{ print $$1 }' | tail -n +3); do \ | ||
| echo "Upgrading $$pkg to latest..."; \ | ||
| @for pkg in $$($(BINGO) list | awk '{ print $$3 }' | tail -n +3 | sed 's/@.*//'); do \ | ||
| echo -e "Upgrading \033[35m$$pkg\033[0m to latest..."; \ | ||
| $(BINGO) get "$$pkg@latest"; \ | ||
| done |
There was a problem hiding this comment.
Worked fine in the MAC as well
Merged
via the queue into
operator-framework:main
with commit Jan 14, 2025
7a6fa07
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current bingo-upgrade make target can choke on bingo dependencies that require the whole path to the executable. For instance, golangci-lint needs to be installed with bingo as follows:
as opposed to:
The update makes use of the 3rd column of the bingo list command:
And uses sed to strip everything after (and including) the
@.I've tested this manually and it worked for every tool.
Reviewer Checklist