🐛 desired state in applier

[azych]

A few minor fixes:

1. internal/applier/helm.go:getReleaseState() contained two if blocks that handled driver.ErrReleaseNotFound with the first one returning, which meant the second block would never run.

   Additionally, the first handler always returned a nil desiredState causing the only currently used Preflight validator (crdupgradesafety) and potentially others in the future to exit immediately because of not having anything to validate.

   This fix leaves only the second handler block in, which actually triggers a dry-run installation and is able to return a proper desiredState that any Preflight validation can work with. It also has the added benefit of potentially spotting any issues and exiting earlier in case the dry-run failed.

2. hack/tools/catalogs/download-catalog script - changes the name of the catalogd service from catalogd-server to the currently used catalogd-service.

3. hack/tools/catalogs/list-compatible-bundles script - adds the missing extract-olm-package-property function to the call chain and uses the correct name of regex filtering function (filter-by-regex-if-necessary), making sure the script works.
The main issues here were two:
1. regex_it did not exist and was renamed during review of the original PR to filter-by-regex-if-necessary
2. extract-olm-package-property call was missing from the chain meaning the filter function couldn't recognize the structure it was expecting

Fixes to hack/tools/catalogs/ scripts have been separated from this PR into PRs of their own: #1546 and #1545 as per #1539 (comment)

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	8060281
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/677f82b3bc03dc000844e89a
😎 Deploy Preview	https://deploy-preview-1539--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.64%. Comparing base (5b5ccab) to head (8060281).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
+ Coverage   74.25%   75.64%   +1.38%     
==========================================
  Files          42       42              
  Lines        3329     3326       -3     
==========================================
+ Hits         2472     2516      +44     
+ Misses        676      638      -38     
+ Partials      181      172       -9     

Flag	Coverage Δ
e2e	52.73% <0.00%> (+0.61%)	⬆️
unit	59.80% <100.00%> (+2.81%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[camilamacedo86]

HI @azych

That seems great !!!
Well done 🥇
Really thank you for adding the tests.

Just a small nits and questions.

[azych]

@camilamacedo86 @joelanford @bentito
I've just squashed the changes and the fix should be ready to go. Please take a look and approve.

I think any potential discussion about #1539 (comment) should not be a blocker and can be had outside (maybe on an issue?) if necessary, WDYT?

[camilamacedo86]

Great work 🥇
/lgtm

[perdasilva]

looks awesome! Thanks for the thorough unit testing ^^