Skip to content

feature!: throw exception if controller cannot be registered #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2021
Merged

feature!: throw exception if controller cannot be registered #641

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1950eb4
feature!: throw exception if controller cannot be registered
csviri Oct 29, 2021
bc40b98
fix: operator exception thrown
csviri Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,11 @@ public void close() {
throws OperatorException {
final var existing = configurationService.getConfigurationFor(controller);
if (existing == null) {
log.warn(
"Skipping registration of {} controller named {} because its configuration cannot be found.\n"
+ "Known controllers are: {}",
controller.getClass().getCanonicalName(),
ControllerUtils.getNameFor(controller),
configurationService.getKnownControllerNames());
throw new IllegalStateException(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be an OperatorException instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed.

"Cannot register controller with name " + controller.getClass().getCanonicalName() +
" controller named " + ControllerUtils.getNameFor(controller)
+ " because its configuration cannot be found.\n" +
" Known controllers are: " + configurationService.getKnownControllerNames());
} else {
if (configuration == null) {
configuration = existing;
Expand Down