DefaultEventHandler should not fire events if the handler is being closed #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lburgazzoli
force-pushed
the
event-handler
branch
2 times, most recently
from
6da0fcb to
f966d1d
Compare
csviri
approved these changes
Oct 4, 2021
metacosm
reviewed
Oct 4, 2021
| defaultEventHandler.close(); | ||
| defaultEventHandler.handleEvent(prepareCREvent()); | ||
|
|
||
| verify(eventDispatcherMock, timeout(50).times(1)).handleExecution(any()); |
There was a problem hiding this comment.
Shouldn't we not dispatch at all if the handler is closed?
There was a problem hiding this comment.
mh yes, don't know why I ended up with this test
There was a problem hiding this comment.
will fix it later today
There was a problem hiding this comment.
@metacosm fixed
lburgazzoli
force-pushed
the
event-handler
branch
from
f966d1d to
41b5d06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #578