-
Notifications
You must be signed in to change notification settings - Fork 222
feat: extract micrometer support into its own module #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Made some comments on the original issue |
I'm not against this, it makes sense. Just wonder if has that much added benefit, while we introduce an additional module. But again I'm not against this. |
I think the split makes sense however I think we should reason a little bit more about how metrics related bits are added into the code as example for what concerns https://github.com/java-operator-sdk/java-operator-sdk/blob/4d36922c90c49767a355c44006fc5586fe91a967/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/DefaultEventHandler.java#L35-L44 In the code above we are saying:
So I wonder if instead, if metrics are enabled, then we should instantiate a |
Definitely, will take a look on that also soon. Maybe we can discuss that under a new issue, and we can discuss the design there. What I don't like on micrometer core that is has bunch of dependencies. That is a good argument to not have it on the classpath by default. So if you insist to merge this I'm fine. Just let's think in the future if it really has the benefit, since we have to then create additional abstractions for this in core. |
@csviri @lburgazzoli I changed how we deal with |
LGTM |
Fixes #576. This allows getting rid of mandatory micrometer dependency if users are not interested in having metrics.
The goal is to not rely on DefaultEventHandler eventually. EventMonitor was kept on DefaultEventHandler for backwards compatibility reason but this should be moved to its own package along with the Metrics class for v2
dfe8474
to
d821610
Compare
Fixes #576. This allows getting rid of mandatory micrometer dependency
if users are not interested in having metrics.