fix: shut down operator when failing to start

.github/workflows/snapshot-releases.yml

@@ -8,7 +8,7 @@ concurrency:
   cancel-in-progress: true
 on:
   push:
-    branches: [ main, v1, next ]
+    branches: [ main, v1, v2, next ]
   workflow_dispatch:
 jobs:
   test:

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java

@@ -66,20 +66,25 @@ public List<Controller> getControllers() {
    * and start the cluster monitoring processes.
    */
   public void start() {
-    controllers.shouldStart();
-
-    final var version = configurationService.getVersion();
-    log.info(
-        "Operator SDK {} (commit: {}) built on {} starting...",
-        version.getSdkVersion(),
-        version.getCommit(),
-        version.getBuiltTime());
-
-    final var clientVersion = Version.clientVersion();
-    log.info("Client version: {}", clientVersion);
-
-    ExecutorServiceManager.init(configurationService);
-    controllers.start();
+    try {
+      controllers.shouldStart();
+
+      final var version = configurationService.getVersion();
+      log.info(
+          "Operator SDK {} (commit: {}) built on {} starting...",
+          version.getSdkVersion(),
+          version.getCommit(),
+          version.getBuiltTime());
+
+      final var clientVersion = Version.clientVersion();
+      log.info("Client version: {}", clientVersion);
+
+      ExecutorServiceManager.init(configurationService);
+      controllers.start();
+    } catch (Exception e) {
+      log.error("Error starting operator", e);
+      System.exit(1);
+    }
   }
 
   @Override

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/timer/TimerEventSource.java

@@ -20,7 +20,7 @@ public class TimerEventSource<R extends HasMetadata>
     implements ResourceEventAware<R> {
   private static final Logger log = LoggerFactory.getLogger(TimerEventSource.class);
 
-  private final Timer timer = new Timer();
+  private final Timer timer = new Timer(true);
   private final AtomicBoolean running = new AtomicBoolean();
   private final Map<ResourceID, EventProducerTimeTask> onceTasks = new ConcurrentHashMap<>();
 

sample-operators/mysql-schema/src/main/java/io/javaoperatorsdk/operator/sample/MySQLSchemaReconciler.java

@@ -15,7 +15,16 @@
 import io.fabric8.kubernetes.api.model.Secret;
 import io.fabric8.kubernetes.api.model.SecretBuilder;
 import io.fabric8.kubernetes.client.KubernetesClient;
-import io.javaoperatorsdk.operator.api.reconciler.*;
+import io.javaoperatorsdk.operator.api.reconciler.Constants;
+import io.javaoperatorsdk.operator.api.reconciler.Context;
+import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration;
+import io.javaoperatorsdk.operator.api.reconciler.DeleteControl;
+import io.javaoperatorsdk.operator.api.reconciler.ErrorStatusHandler;
+import io.javaoperatorsdk.operator.api.reconciler.EventSourceContext;
+import io.javaoperatorsdk.operator.api.reconciler.EventSourceInitializer;
+import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
+import io.javaoperatorsdk.operator.api.reconciler.RetryInfo;
+import io.javaoperatorsdk.operator.api.reconciler.UpdateControl;
 import io.javaoperatorsdk.operator.processing.event.source.EventSource;
 import io.javaoperatorsdk.operator.processing.event.source.polling.PerResourcePollingEventSource;
 import io.javaoperatorsdk.operator.sample.schema.Schema;
@@ -57,7 +66,8 @@ public UpdateControl<MySQLSchema> reconcile(MySQLSchema schema, Context context)
       if (dbSchema.isEmpty()) {
         log.debug("Creating Schema and related resources for: {}", schema.getMetadata().getName());
         var schemaName = schema.getMetadata().getName();
-        String password = RandomStringUtils.randomAlphanumeric(16);
+        String password = RandomStringUtils
+            .randomAlphanumeric(16); // NOSONAR: cryptographically-strong randomness unneeded
         String secretName = String.format(SECRET_FORMAT, schemaName);
         String userName = String.format(USERNAME_FORMAT, schemaName);