Skip to content

feat: add managed dependent webpage reconciler implementation #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 22, 2022
Merged

feat: add managed dependent webpage reconciler implementation #1050

merged 6 commits into from
Mar 22, 2022

Conversation

metacosm
Copy link
Collaborator

  • feat: give explicit access to client from KubernetesClientAware
  • refactor: WebPageReconcilerDependentResources -> WebPageStandaloneDependentsReconciler
  • refactor: extract methods into Utils, extract dependent resources
  • fix: make Utils.simulateErrorIfRequested throw exception
  • feat: add managed dependent reconciler implementation
  • fix: unify artifactId

@metacosm metacosm self-assigned this Mar 18, 2022
@metacosm metacosm requested a review from csviri March 18, 2022 21:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 64 Code Smells

39.8% 39.8% Coverage
0.3% 0.3% Duplication

csviri
csviri requested changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that I'm missing to add the new managed dependent resources to the E2E tests. Otherwise LGTM.

@metacosm
Copy link
Collaborator Author

One thing that I'm missing to add the new managed dependent resources to the E2E tests. Otherwise LGTM.

Yes, I wasn't sure if we wanted to do that so I didn't look into it.

csviri
csviri approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also merge this now , and add the E2E as a separate PR.

@metacosm metacosm merged commit cb1fa11 into next Mar 22, 2022
@metacosm metacosm deleted the improve-webpage-sample branch March 22, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metacosm @csviri