Conversation
Member
|
sorry but I think readback on query will break due to the complexity of the binary annotation type.. openzipkin/zipkin-api#27 |
Member
|
there's a lot of links about how to do vary on type, but I noticed if I switched the binary annotation to interface it doesn't cry anymore. Not necessarily helpful, but yeah.. openzipkin/zipkin-api#27 (comment) next step on openapi is to figure out the openapi spec that is correct for binaryannotation.value (anyOf I think) |
Member
|
I just started the v2 format which seems to work! openzipkin/zipkin-api#33 |
Member
|
added this which works with the lastest api definition. Thanks for all the ground work here! a13b515 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.