backport enforce arc_dnode_limit to 2.2 #17583
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is a backport of a7a144e ("enforce arc_dnode_limit") for the 2.2 branch. back-ported from commit a7a144e working around changes from: 55427ad ("Several improvements to ARC shrinking (openzfs#16197)") 5b9f3b7 ("Soften pruning threshold on not evictable metadata") which are present in 2.3.3, but not in 2.2.8 Tested-by: Friedrich Weber <[email protected]> Signed-off-by: Stoiko Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This patch is a backport of a7a144e ("enforce arc_dnode_limit")
a7a144e
for the 2.2 branch.
According to a simple reproducer of a colleague of mine the patch causes the dnode cache to shrink again after growing, while it remains at a high level without it. See the discussion (with details on the reproducer) at:
https://lore.proxmox.com/pve-devel/[email protected]/
for details on the reproducer.
Description
Started with a cherry-pick of
a7a144e65and adapted the code to changes from55427ad ("Several improvements to ARC shrinking (#16197)")
5b9f3b7 ("Soften pruning threshold on not evictable metadata")
which are present in 2.3.3, but not in 2.2.8
I'm not familiar with that part of the code - so the changes might be missing something.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.