Skip to content

Fix TestGroup warning due to missing tags #17473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Conversation

pcd1193182
Copy link
Contributor

Motivation and Context

Warning: TestGroup '/home/pcd/zfs/tests/zfs-tests/tests/functional/syncfs' not added to
this run. Auxiliary script '/home/pcd/zfs/tests/zfs-tests/tests/functional/syncfs/setup' failed
verification.

Description

Add the missing tags to the runfile section for syncfs

How Has This Been Tested?

Ran the test suite, verified that the group no longer gets excluded

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@pcd1193182 pcd1193182 requested a review from robn June 19, 2025 18:01
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Jun 19, 2025
Copy link
Member

@robn robn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgh yeah, removed no-op setup/cleanup late in #17420; I felt like I had them there for a reason. Made a note to make the runfile stuff understand it next time I'm touring ZTS.

Thanks @pcd1193182.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jun 19, 2025
@behlendorf behlendorf merged commit 8170eb6 into openzfs:master Jun 19, 2025
20 of 24 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 13, 2025
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Signed-off-by: Paul Dagnelie <[email protected]>
Co-authored-by: Paul Dagnelie <[email protected]>
Closes openzfs#17473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants