Skip to content

ioctl: remove FICLONE/FICLONERANGE/FIDEDUPERANGE compat #17308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

ioctl: remove FICLONE/FICLONERANGE/FIDEDUPERANGE compat #17308

merged 1 commit into from
May 8, 2025

Conversation

robn
Copy link
Member

@robn robn commented May 7, 2025

Motivation and Context

Target of opportunity.

Description

These are only required to support these ioctls on Linux <4.5. Since 4.18 is our cutoff, we don't need this code anymore.

Also removing related test things that will never match again.

How Has This Been Tested?

Compile checked on 4.19, 5.10, 6.1, 6.8.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@robn
ioctl: remove FICLONE/FICLONERANGE/FIDEDUPERANGE compat
22d9938 
These are only required to support these ioctls on Linux <4.5. Since
4.18 is our cutoff, we don't need this code anymore.

Also removing related test things that will never match again.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <[email protected]>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label May 7, 2025
tonyhutter
tonyhutter approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@tonyhutter tonyhutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@tonyhutter tonyhutter added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 7, 2025
@amotin amotin merged commit 4800181 into openzfs:master May 8, 2025
24 checks passed
ixhamza pushed a commit to truenas/zfs that referenced this pull request May 14, 2025
@robn @ixhamza
ioctl: remove FICLONE/FICLONERANGE/FIDEDUPERANGE compat
c74547e 
These are only required to support these ioctls on Linux <4.5. Since
4.18 is our cutoff, we don't need this code anymore.

Also removing related test things that will never match again.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#17308
ixhamza pushed a commit to truenas/zfs that referenced this pull request May 14, 2025
@robn @ixhamza
ioctl: remove FICLONE/FICLONERANGE/FIDEDUPERANGE compat
1c975c0 
These are only required to support these ioctls on Linux <4.5. Since
4.18 is our cutoff, we don't need this code anymore.

Also removing related test things that will never match again.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#17308
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 13, 2025
@robn @behlendorf
ioctl: remove FICLONE/FICLONERANGE/FIDEDUPERANGE compat
4eb757d 
These are only required to support these ioctls on Linux <4.5. Since
4.18 is our cutoff, we don't need this code anymore.

Also removing related test things that will never match again.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#17308
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 16, 2025
@robn @behlendorf
ioctl: remove FICLONE/FICLONERANGE/FIDEDUPERANGE compat
ed60b10 
These are only required to support these ioctls on Linux <4.5. Since
4.18 is our cutoff, we don't need this code anymore.

Also removing related test things that will never match again.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#17308
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 16, 2025
@robn @behlendorf
ioctl: remove FICLONE/FICLONERANGE/FIDEDUPERANGE compat
480e7c1 
These are only required to support these ioctls on Linux <4.5. Since
4.18 is our cutoff, we don't need this code anymore.

Also removing related test things that will never match again.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#17308
behlendorf pushed a commit that referenced this pull request Jun 17, 2025
@robn @behlendorf
ioctl: remove FICLONE/FICLONERANGE/FIDEDUPERANGE compat
f9504cf 
These are only required to support these ioctls on Linux <4.5. Since
4.18 is our cutoff, we don't need this code anymore.

Also removing related test things that will never match again.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes #17308
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jun 17, 2025
@robn @behlendorf
ioctl: remove FICLONE/FICLONERANGE/FIDEDUPERANGE compat
b00bc81 
These are only required to support these ioctls on Linux <4.5. Since
4.18 is our cutoff, we don't need this code anymore.

Also removing related test things that will never match again.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#17308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robn @amotin @tonyhutter