Fix model download issue: Download both .xml and .bin files #3012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates model download code to properly download both .xml (architecture) and .bin (weights) files - Fixes RuntimeError: 'Empty weights data in bin file or bin file cannot be found!' - Ensures both person-detection-0202 and person-reidentification-retail-0287 models work correctly - Cleans up execution outputs from notebook cells
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -172,23 +172,34 @@ | |||
| "# A directory where the model will be downloaded.\n", | |||
There was a problem hiding this comment.
Line #15. download_ir_model(download_det_model_xml_url, Path(base_model_dir) / detection_model_name / precision)
download_ir_model accepts xml url, and then download bin and xml files. It checks separately if each of them already exists and downloads if not. So, it is enough to removeif not detection_model_path.exists(): and if not reidentification_model_path.exists():
Reply via ReviewNB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix model download and execution issues for person detection and re-identification
What changed
This PR addresses an issue where the model downloader was only fetching the
.xml(model architecture) file but not the corresponding.bin(model weights) file for OpenVINO models. This mismatch caused runtime errors like:Why this was needed
Both the
.xmland.binfiles are required for OpenVINO IR (Intermediate Representation) models to run inference. Without the weights file, the model can't load or perform any predictions. Users trying to run the person detection (person-detection-0202) or person re-identification (person-reidentification-retail-0287) pipelines were hitting this error.What models are impacted
These models are often used together for multi-step pipelines (e.g., detect a person, then re-identify them across frames or cameras).
What I did
.xmland.binfiles for each model are downloaded and available at runtime.How to test
.xmland.binfiles exist in the expected download directory.Before this fix:
Running inference would fail with missing weights error.
After this fix:
Both models load successfully and inference runs as expected.