use JSON instead of XML for (almost) all OSM APIs #11661
+113
−397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
except changesets, which don't support JSON yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can remove almost all the XML parsing code by using the OSM API's json endpoints. Deleted about 250 lines of code.
We already use the new JSON endpoints for most things. This PR migrates the last few endspoints:
/api/capabilities.json/api/0.6/notes.json/api/0.6/notes/{id}.json/api/0.6/notes/{id}/{action}.json/api/0.6/changesets.jsonThis is faster, simpler, and makes the code more concise.
The last remaining endpoint that doesn't support JSON is uploading changesets, which is tracked by openstreetmap/openstreetmap-website#5973
affected parts of the UI:
commentdropdown