Move Ceph playbook into hooks #3154
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
danpawlik
force-pushed
the
move-ceph-into-hooks
branch
from
522dde1 to
cbce513
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c51fd93f68f04784940931becc8c3ff6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 36m 47s |
danpawlik
force-pushed
the
move-ceph-into-hooks
branch
2 times, most recently
from
b236189 to
cf5861b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5029b8e685c14b60b2ee1048289da2e2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 05s |
danpawlik
force-pushed
the
move-ceph-into-hooks
branch
from
cf5861b to
812e445
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e33dfee9c20049928220e5eef321ec32 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 27m 15s |
danpawlik
force-pushed
the
move-ceph-into-hooks
branch
from
812e445 to
e8a6adf
Compare
|
danpawlik
force-pushed
the
move-ceph-into-hooks
branch
2 times, most recently
from
aefe56d to
09e68da
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b25a4ca3423e4f33932b70bd78e48e6e ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 22m 43s |
danpawlik
force-pushed
the
move-ceph-into-hooks
branch
4 times, most recently
from
d0e5f5f to
43d3040
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0f6f38421a724d648f05b508deb8fefd ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 16m 28s |
|
This PR is stale because it has been for over 15 days with no activity. |
danpawlik
force-pushed
the
move-ceph-into-hooks
branch
from
43d3040 to
4c82b6f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dae45cb64dbd44b992a22d386e59ad20 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 17m 14s |
danpawlik
force-pushed
the
move-ceph-into-hooks
branch
from
4c82b6f to
d98b7b4
Compare
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/48d83803a2a54f92a829402bfd393de4 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 49m 02s |
|
recheck |
danpawlik
force-pushed
the
move-ceph-into-hooks
branch
from
b228dca to
8841c7c
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d8aa777b9ea64183987e41da8860e134 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 28s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3aace6ec17b74f3795d9abbb5aca2975 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 12s |
|
recheck |
|
should this pr also update the ceph playbook CODEOWNERS entry? |
TBH we are still not maintaining that play, just "fit" it to our requirements. |
We would like to avoid tasks, where we do 'import_playbook'. In that case, instead of split ceph playbook into role (now), let's keep the playbook as it is (because it is used in few places) and run that play using hooks, like we do with other additional services. Until migration process is not done (many projects are using that playbook), there is a symlink done to old location, so we should avoid outage. Related-to: openstack-k8s-operators/install_yamls#1083 Related-to: openstack-k8s-operators/architecture#604 Signed-off-by: Daniel Pawlik <[email protected]>
danpawlik
force-pushed
the
move-ceph-into-hooks
branch
from
8841c7c to
54b9272
Compare
There was a problem hiding this comment.
The symlink is in place so this should be safe.
I see some calls which are replaced with importing the hook which won't be protected with that though I know there has been testing. I'm OK with merging this and if there's an issue we can revert.
Thanks @danpawlik
After merging change [1], the places where Ceph playbook was used, have been moved to use hooks. Let's drop the symlink and verify in all used job, that the playbook path has been updated correctly. [1] openstack-k8s-operators#3154 Signed-off-by: Daniel Pawlik <[email protected]>
We would like to avoid tasks, where we do 'import_playbook'.
In that case, instead of split ceph playbook into role (now),
let's keep the playbook as it is (because it is used in few places)
and run that play using hooks, like we do with other additional
services.
Until migration process is not done (many projects are using that
playbook), there is a symlink done to old location, so we should avoid
outage.
Related-to: openstack-k8s-operators/install_yamls#1083
Related-to: openstack-k8s-operators/architecture#604