Skip to content

Add logos & validation script #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lorenz234
Copy link
Contributor

Hi OSO-team,

In this PR, I’ve added all the logos we currently have.
To organize them, we created a new data/logos/ folder, which contains subfolders for each letter and number (a–z, 0–9), based on the first character of the logo filename.

I’ve also updated the GitHub Action to validate that each logo has a corresponding project YAML file. If a logo is not mapped to a project (i.e., no matching .yaml file in data/projects/), the workflow will now throw a validation error.
To enable this, each logo file is named identically to its corresponding project.

This is my first time working with GitHub Actions — the new check worked locally on my fork (see image below), but I’m not entirely sure if I integrated it correctly into the overall workflow. Would appreciate a quick review of that part!

Screenshot 2025-03-28 at 12 22 31

@ryscheng
Copy link
Member

ryscheng commented Jul 10, 2025

@lorenz234 this is awesome! Thanks so much for working on this!

Couple thoughts:

  • The images themselves are so large, that it makes it impossible to actually load the validation code in the GitHub web app for review. Can we separate this into 2 PRs? One with the logo data and one with the validation logic?
  • For the validation logic, I'd suggest adding the validation logic directly in src/cli.ts, and running it from the ci-default GitHub action, like we do with the current schema validation logic.
  • The validation logic also seems to be missing? Is this something you already contributed somewhere else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants