Skip to content

Update devfile registry to use go 1.21 and OpenShift 4.15 #53126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2024
Merged

Update devfile registry to use go 1.21 and OpenShift 4.15 #53126

merged 2 commits into from
Jun 12, 2024

Conversation

michael-valdron
Copy link
Member

Description

Devfile registry will be using golang 1.21 after pending changes: devfile/registry#420

blocking devfile/api#1558

@michael-valdron
update to go 1.21 devfile registry
8ab9573 
Signed-off-by: Michael Valdron <[email protected]>
@openshift-ci openshift-ci bot requested review from elsony and johnmcollier June 12, 2024 14:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
@michael-valdron
Copy link
Member Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 12, 2024
@michael-valdron
Copy link
Member Author

/pj-rehearse reject

Need to bump OpenShift to ensure best compatibility with Kubernetes 1.29

@openshift-ci-robot
Copy link
Contributor

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 12, 2024
@michael-valdron
Copy link
Member Author

/pj-rehearse abort

@openshift-ci-robot
Copy link
Contributor

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@michael-valdron
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2024
@michael-valdron michael-valdron mentioned this pull request Jun 12, 2024
Merged
4 tasks
@michael-valdron michael-valdron changed the title Update devfile registry to use go 1.21 Update devfile registry to use go 1.21 and OpenShift 4.15 Jun 12, 2024
@michael-valdron
Copy link
Member Author

/unhold
/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@michael-valdron: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-devfile-registry-main-v4.15-images devfile/registry presubmit Presubmit changed
pull-ci-devfile-registry-main-v4.15-registry-test devfile/registry presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@michael-valdron
Copy link
Member Author

Should really update to OpenShift 4.16 when stable is released.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 12, 2024
@michael-valdron michael-valdron mentioned this pull request Jun 12, 2024
Closed
4 tasks
maysunfaisal
maysunfaisal approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 43c2b01 into openshift:master Jun 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

@michael-valdron: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lihongyan1 pushed a commit to lihongyan1/release that referenced this pull request Jun 20, 2024
@michael-valdron @lihongyan1
Update devfile registry to use go 1.21 and OpenShift 4.15 (openshift#…
11b2c47 
…53126)

* update to go 1.21 devfile registry

Signed-off-by: Michael Valdron <[email protected]>

* update to OpenShift 4.15 devfile registry

Signed-off-by: Michael Valdron <[email protected]>

---------

Signed-off-by: Michael Valdron <[email protected]>
This was referenced Mar 13, 2025
Closed
Open
Closed
@michael-valdron michael-valdron mentioned this pull request May 30, 2025
Closed
5 tasks
@thepetk thepetk mentioned this pull request Jun 5, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsony elsony Awaiting requested review from elsony

@johnmcollier johnmcollier Awaiting requested review from johnmcollier

1 more reviewer

@maysunfaisal maysunfaisal maysunfaisal approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@maysunfaisal maysunfaisal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-valdron @openshift-ci-robot @maysunfaisal