accept --kubeconfig like kubectl #20721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/M
soltysh
approved these changes
Aug 22, 2018
Contributor
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
One nit and you're good to go.
test/cmd/login.sh
Outdated
| os::cmd::expect_success_and_text 'oc config view' "current-context.+project-foo/${API_HOST}:${API_PORT}/test-user" | ||
| os::cmd::expect_success_and_text 'oc whoami' 'test-user' | ||
| os::cmd::expect_success_and_text "oc whoami --config='${login_kubeconfig}'" 'system:admin' | ||
| os::cmd::expect_success_and_text "oc whoami --kubeconfig='${login_kubeconfig}'" 'system:admin' |
Contributor
There was a problem hiding this comment.
I think you wanted one to be --config to verify it still works, right?
deads2k
force-pushed
the
cli-02-kubeconfig
branch
from
16a6227 to
8045bb4
Compare
Contributor
Author
|
updated. |
openshift-ci-robot
added
size/XL
deads2k
force-pushed
the
cli-02-kubeconfig
branch
from
8045bb4 to
f20c0a4
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
/approve
…On Wed, Aug 22, 2018 at 7:41 PM David Eads ***@***.***> wrote:
/retest
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20721 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p8y2NNEdvvYSTS4lEStOo48eoR0Uks5uTewygaJpZM4WGmdo>
.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the final remaining
oc/kubectlinconsistencies is--kubeconfig. We take--configinstead, but that collides in commands taking config in weird ways. This updatesocto accept either for the time being.@openshift/cli-review
I doubt we get to drop
--configsupport anytime soon, but this gives us compatibility and we could write a decent plugin after this@smarterclayton I think this is the last big one
/assign @soltysh