Skip to content

Conversation

bscott-rh
Copy link
Contributor

@bscott-rh bscott-rh commented Aug 25, 2025

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 25, 2025
@bscott-rh bscott-rh changed the title Adding icr.io to firewall allowlist for IBM CloudPak OCPBUGS#60854 Adding icr.io to firewall allowlist for IBM CloudPak Aug 25, 2025
@bscott-rh
Copy link
Contributor Author

bscott-rh commented Aug 25, 2025

@sgaoshang Hello Shang, can you please take a look at this docs PR adding IBM's icr.io to the firewall allowlist to accommodate IBM CloudPak customers? Thank you
cc @gpei I'm not sure which QE associate might be able to review this.

@sferich888
Copy link
Contributor

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 25, 2025
Copy link

@pgodowski pgodowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One wording update request, plus list both icr.io and cp.icr.io

@@ -81,6 +81,10 @@ If your environment has a dedicated load balancer in front of your {product-titl
|`sso.redhat.com`
|443
|The `https://console.redhat.com` site uses authentication from `sso.redhat.com`

|`icr.io`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add both icr.io and cp.icr.io


|`icr.io`
|443
|Provides IBM CloudPak images. This domain is only required if you use IBM CloudPaks.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|Provides IBM CloudPak images. This domain is only required if you use IBM CloudPaks.
|Provides IBM Cloud Pak container images. This domain is only required if you use IBM Cloud Paks.

Copy link

openshift-ci bot commented Sep 2, 2025

@bscott-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gpei
Copy link

gpei commented Sep 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2025
@bscott-rh bscott-rh added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 3, 2025
@dfitzmau dfitzmau removed the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 3, 2025
@dfitzmau dfitzmau added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 3, 2025
@dfitzmau dfitzmau merged commit f01aff8 into openshift:main Sep 3, 2025
2 checks passed
@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 3, 2025

/cherrypick enterprise-4.20

@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 3, 2025

/cherrypick enterprise-4.19

@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 3, 2025

/cherrypick enterprise-4.18

@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 3, 2025

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 3, 2025

/cherrypick enterprise-4.16

@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 3, 2025

/cherrypick enterprise-4.15

@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 3, 2025

/cherrypick enterprise-4.14

@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 3, 2025

/cherrypick enterprise-4.13

@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 3, 2025

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #98414

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #98415

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #98416

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #98417

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #98418

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #98419

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #98420

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #98421

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #98422

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR px-approved Signifies that Product Support has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants