-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS#60854 Adding icr.io to firewall allowlist for IBM CloudPak #97988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sgaoshang Hello Shang, can you please take a look at this docs PR adding IBM's |
/label px-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One wording update request, plus list both icr.io and cp.icr.io
@@ -81,6 +81,10 @@ If your environment has a dedicated load balancer in front of your {product-titl | |||
|`sso.redhat.com` | |||
|443 | |||
|The `https://console.redhat.com` site uses authentication from `sso.redhat.com` | |||
|
|||
|`icr.io` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add both icr.io
and cp.icr.io
modules/configuring-firewall.adoc
Outdated
|
||
|`icr.io` | ||
|443 | ||
|Provides IBM CloudPak images. This domain is only required if you use IBM CloudPaks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|Provides IBM CloudPak images. This domain is only required if you use IBM CloudPaks. | |
|Provides IBM Cloud Pak container images. This domain is only required if you use IBM Cloud Paks. |
5216495
to
4891d40
Compare
@bscott-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
/cherrypick enterprise-4.20 |
/cherrypick enterprise-4.19 |
/cherrypick enterprise-4.18 |
/cherrypick enterprise-4.17 |
/cherrypick enterprise-4.16 |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.12 |
@dfitzmau: new pull request created: #98414 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dfitzmau: new pull request created: #98415 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dfitzmau: new pull request created: #98416 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dfitzmau: new pull request created: #98417 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dfitzmau: new pull request created: #98418 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dfitzmau: new pull request created: #98419 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dfitzmau: new pull request created: #98420 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dfitzmau: new pull request created: #98421 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dfitzmau: new pull request created: #98422 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.12+
Issue:
OCPBUGS-60854
Link to docs preview:
https://97988--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/install_config/configuring-firewall.html#configuring-firewall_configuring-firewall
QE review: