OSDOCS-14933:Feedback from SME reviewer for HCP Storage book. #95142

AedinC · 2025-06-24T10:01:41Z

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14933

Link to docs preview:

Peer review:

Peer reviewer has approved this change.

SME review:

SME has approved this change.

QE review:

QE has approved this change.

Additional information:

openshift-ci-robot · 2025-06-24T10:01:46Z

@AedinC: This pull request references OSDOCS-14933 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14933

Link to docs preview:

Peer review:

Peer reviewer has approved this change.

SME review:

SME has approved this change.

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2025-06-24T10:25:46Z

🤖 Thu Jun 26 10:08:40 - Prow CI generated the docs preview:
https://95142--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

ocpdocs-vale-bot · 2025-06-24T10:26:24Z

modules/storage-persistent-storage-pv.adoc

-1. RWOP uses the SELinux mount feature. This feature is driver dependent, and enabled by default in ODF, AWS EBS, Azure Disk, GCP PD, IBM Cloud Block Storage volume, Cinder, and vSphere. For third-party drivers, please contact your storage vendor.
+1. RWOP uses the SELinux mount feature. This feature is driver dependent, and enabled by default in AWS EBS
+ifndef::openshift-dedicated,openshift-rosa,openshift-rosa-hcp[]
+, Azure Disk, GCP PD, IBM Cloud Block Storage volume, Cinder, vSphere,


🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{ibm-cloud-title}' rather than the plain text product term 'IBM Cloud', unless your use case is an exception.

ocpdocs-vale-bot · 2025-06-24T15:07:33Z

microshift_install_get_ready/microshift-install-get-ready.adoc

@@ -79,7 +79,7 @@ For most installation types, you must also take the following steps:

 * Decide whether you need to configure storage for the application and tasks you are using in your {microshift-short} cluster, or disable the {microshift-short} storage plug-in completely.
 ** For more information about creating volume groups and persistent volumes on {op-system-base}, see link:https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/configuring_and_managing_logical_volumes/overview-of-logical-volume-management_configuring-and-managing-logical-volumes[Overview of logical volume management].
-** For more information about the {microshift-short} plug-in, see xref:../microshift_storage/microshift-storage-plugin-overview.adoc#microshift-storage-plugin-overview[Dynamic storage using the LVMS plugin].
+** For more information about the {microshift-short} plug-in, see xref:../microshift_storage/microshift-storage-plugin-overview.adoc[Dynamic storage using the LVMS plugin].


🤖 [error] OpenShiftAsciiDoc.XrefContainsAnchorID: The xref is missing an anchor ID.

ocpdocs-vale-bot · 2025-06-24T15:07:35Z

microshift_storage/index.adoc

@@ -26,7 +26,7 @@ Stateful applications deployed in containers require persistent storage. {micros
 [id="microshift-dynamic-provisioning-overview"]
 === Dynamic storage provisioning

-Using dynamic provisioning allows you to create storage volumes on-demand, eliminating the need for pre-provisioned storage. For more information about how dynamic provisioning works in {product-title}, read xref:../microshift_storage/microshift-storage-plugin-overview.adoc#microshift-storage-plugin-overview[Dynamic provisioning].
+Using dynamic provisioning allows you to create storage volumes on-demand, eliminating the need for pre-provisioned storage. For more information about how dynamic provisioning works in {product-title}, read xref:../microshift_storage/microshift-storage-plugin-overview.adoc[Dynamic provisioning].


🤖 [error] OpenShiftAsciiDoc.XrefContainsAnchorID: The xref is missing an anchor ID.

openshift-ci-robot · 2025-06-25T10:35:10Z

@AedinC: This pull request references OSDOCS-14933 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14933

Link to docs preview:
Red Hat OpenShift Service on AWS storage overview

Peer review:

Peer reviewer has approved this change.

SME review:

SME has approved this change.

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mletalie

/label peer-review-in-progress

openshift-ci-robot · 2025-06-25T15:09:09Z

@AedinC: This pull request references OSDOCS-14933 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14933

Link to docs preview:

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/container_storage_interface/persistent-storage-csi-aws-efs.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/container_storage_interface/persistent-storage-csi.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/container_storage_interface/persistent-storage-csi-sc-manage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/dynamic-provisioning.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/expanding-persistent-volumes.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/generic-ephemeral-vols.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/persistent_storage/persistent-storage-aws.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/understanding-ephemeral-storage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/understanding-persistent-storage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/container_storage_interface/persistent-storage-csi-sc-manage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/expanding-persistent-volumes.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/generic-ephemeral-vols.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/persistent_storage/persistent-storage-aws.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/understanding-ephemeral-storage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/understanding-persistent-storage.htmltm

Peer review:

Peer reviewer has approved this change.

SME review:

SME has approved this change.

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-06-25T15:09:27Z

@AedinC: This pull request references OSDOCS-14933 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14933

Link to docs preview:

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/container_storage_interface/persistent-storage-csi-aws-efs.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/container_storage_interface/persistent-storage-csi.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/container_storage_interface/persistent-storage-csi-sc-manage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/dynamic-provisioning.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/expanding-persistent-volumes.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/generic-ephemeral-vols.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/persistent_storage/persistent-storage-aws.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/understanding-ephemeral-storage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/understanding-persistent-storage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/container_storage_interface/persistent-storage-csi-sc-manage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/expanding-persistent-volumes.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/generic-ephemeral-vols.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/persistent_storage/persistent-storage-aws.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/understanding-ephemeral-storage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/understanding-persistent-storage.html

Peer review:

Peer reviewer has approved this change.

SME review:

SME has approved this change.

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mletalie

/label peer-review-done
/remove-label peer-review-in-progress

modules/persistent-storage-csi-drivers-supported.adoc

modules/persistent-storage-csi-mysql-example.adoc

storage/container_storage_interface/persistent-storage-csi.adoc

modules/storage-ephemeral-storage-manage.adoc

mletalie · 2025-06-25T16:28:23Z

@AedinC, just a couple of comments, otherwise your changes LGTM!

openshift-ci · 2025-06-26T10:09:56Z

@AedinC: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-06-26T13:49:01Z

@AedinC: This pull request references OSDOCS-14933 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14933

Link to docs preview:

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/container_storage_interface/persistent-storage-csi-aws-efs.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/container_storage_interface/persistent-storage-csi.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/container_storage_interface/persistent-storage-csi-sc-manage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/dynamic-provisioning.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/expanding-persistent-volumes.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/generic-ephemeral-vols.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/persistent_storage/persistent-storage-aws.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/understanding-ephemeral-storage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/understanding-persistent-storage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/container_storage_interface/persistent-storage-csi-sc-manage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/expanding-persistent-volumes.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/generic-ephemeral-vols.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/persistent_storage/persistent-storage-aws.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/understanding-ephemeral-storage.html

https://95142--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/understanding-persistent-storage.html

Peer review:

Peer reviewer has approved this change.

SME review:

SME has approved this change.

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2025

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 24, 2025

ocpdocs-vale-bot reviewed Jun 24, 2025

View reviewed changes

AedinC force-pushed the OSDOCS-14933 branch 3 times, most recently from 0f0106b to 3bd2fec Compare June 24, 2025 11:17

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2025

AedinC force-pushed the OSDOCS-14933 branch 2 times, most recently from 1c5c2f3 to 391b27f Compare June 24, 2025 14:51

ocpdocs-vale-bot reviewed Jun 24, 2025

View reviewed changes

AedinC force-pushed the OSDOCS-14933 branch from 7b6d658 to ff51e08 Compare June 25, 2025 09:30

mletalie reviewed Jun 25, 2025

View reviewed changes

openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 25, 2025

mletalie reviewed Jun 25, 2025

View reviewed changes

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 25, 2025

OSDOCS-14933:Feedback from SME reviewer for HCP Storage book.

315ca83

AedinC force-pushed the OSDOCS-14933 branch from ff51e08 to 315ca83 Compare June 26, 2025 10:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

OSDOCS-14933:Feedback from SME reviewer for HCP Storage book. #95142

OSDOCS-14933:Feedback from SME reviewer for HCP Storage book. #95142

AedinC commented Jun 24, 2025 •

edited

Loading

Uh oh!

openshift-ci-robot commented Jun 24, 2025 •

edited by openshift-ci bot

Loading

Uh oh!

ocpdocs-previewbot commented Jun 24, 2025 •

edited

Loading

Uh oh!

ocpdocs-vale-bot Jun 24, 2025

Uh oh!

ocpdocs-vale-bot Jun 24, 2025

Uh oh!

ocpdocs-vale-bot Jun 24, 2025

Uh oh!

openshift-ci-robot commented Jun 25, 2025 •

edited by openshift-ci bot

Loading

Uh oh!

mletalie left a comment

Uh oh!

openshift-ci-robot commented Jun 25, 2025 •

edited by openshift-ci bot

Loading

Uh oh!

openshift-ci-robot commented Jun 25, 2025 •

edited by openshift-ci bot

Loading

Uh oh!

mletalie left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mletalie commented Jun 25, 2025

Uh oh!

openshift-ci bot commented Jun 26, 2025

Uh oh!

openshift-ci-robot commented Jun 26, 2025 •

edited by openshift-ci bot

Loading

Uh oh!

Uh oh!

OSDOCS-14933:Feedback from SME reviewer for HCP Storage book. #95142

Are you sure you want to change the base?

OSDOCS-14933:Feedback from SME reviewer for HCP Storage book. #95142

Conversation

AedinC commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 24, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-vale-bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

ocpdocs-vale-bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

ocpdocs-vale-bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jun 25, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mletalie left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jun 25, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 25, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mletalie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mletalie commented Jun 25, 2025

Uh oh!

openshift-ci bot commented Jun 26, 2025

Uh oh!

openshift-ci-robot commented Jun 26, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

AedinC commented Jun 24, 2025 •

edited

Loading

openshift-ci-robot commented Jun 24, 2025 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Jun 24, 2025 •

edited

Loading

openshift-ci-robot commented Jun 25, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jun 25, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jun 25, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jun 26, 2025 •

edited by openshift-ci bot

Loading