TELCODOCS-2344: cp binary in kmod image #95119
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@StephenJamesSmith: This pull request references TELCODOCS-2344 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/XS
|
🤖 Tue Jun 24 18:39:53 - Prow CI generated the docs preview: |
|
@StephenJamesSmith: This pull request references TELCODOCS-2344 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@StephenJamesSmith: This pull request references TELCODOCS-2344 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@StephenJamesSmith: This pull request references TELCODOCS-2344 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/label telco |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
mburke5678
added
the
peer-review-in-progress
modules/kmm-creating-kmod-image.adoc
Outdated
| @@ -13,3 +13,5 @@ Keep the following in mind when working with the `.ko` files: | |||
|
|
|||
| * In most cases, `<prefix>` should be equal to `/opt`. This is the `Module` CRD's default value. | |||
| * `kernel-version` must not be empty and must be equal to the kernel version the kernel modules were built for. | |||
|
|
|||
| In addition to the `.ko` files, the kmod image also requires the `cp` binary to be present as the `.ko` files are copied from this image to the image-loader worker pod created by the Operator. This is a minimal requirement and no other binary tool is required in the image. | |||
There was a problem hiding this comment.
Per ISG: Do not use (as) to mean because or while.
Not sure which is right:
| In addition to the `.ko` files, the kmod image also requires the `cp` binary to be present as the `.ko` files are copied from this image to the image-loader worker pod created by the Operator. This is a minimal requirement and no other binary tool is required in the image. | |
| In addition to the `.ko` files, the kmod image also requires the `cp` binary to be present while the `.ko` files are copied from this image to the image-loader worker pod created by the Operator. This is a minimal requirement and no other binary tool is required in the image. |
| In addition to the `.ko` files, the kmod image also requires the `cp` binary to be present as the `.ko` files are copied from this image to the image-loader worker pod created by the Operator. This is a minimal requirement and no other binary tool is required in the image. | |
| In addition to the `.ko` files, the kmod image also requires the `cp` binary to be present, because the `.ko` files are copied from this image to the image-loader worker pod created by the Operator. This is a minimal requirement and no other binary tool is required in the image. |
There was a problem hiding this comment.
Also, does image-loader need mark-up? Is this the name of the pod?
image-loaderworker pod
There was a problem hiding this comment.
Changed to "because". Not the name of the pod.
|
@StephenJamesSmith A couple of comments, otherwise LGTM |
mburke5678
added
peer-review-done
StephenJamesSmith
force-pushed
the
TELCODOCS-2344
branch
from
98a873a to
580fffd
Compare
|
@StephenJamesSmith: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
Document the minimum requirements for the kmod image
Version(s):
openshift-4.19
KMMO 2.4
Issue:
https://issues.redhat.com/browse/TELCODOCS-2344
Link to docs preview:
https://95119--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hardware_enablement/kmm-kernel-module-management#kmm-creating-kmod-image_kernel-module-management-operator
Dev: @ybettan
QE: @cdvultur
QE review: