Skip to content

[OSDOCS-15006]: Create RN for https://issues.redhat.com/browse/OSDOCS-10294 #95118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

mletalie
Copy link
Contributor

@mletalie mletalie commented Jun 23, 2025

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 23, 2025

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2025
@mletalie mletalie changed the title Osdocs 15006 [OSDOCS-15006]: Create RN for https://issues.redhat.com/browse/OSDOCS-10294 Jun 23, 2025
@mletalie mletalie force-pushed the OSDOCS-15006 branch 2 times, most recently from b873d0d to a946bbf Compare June 23, 2025 19:47
@AedinC
Copy link
Contributor

AedinC commented Jun 24, 2025

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 24, 2025
Copy link
Contributor

@AedinC AedinC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-in-progress
/label peer-review-done
/lgtm

All good - just one tiny change.

@@ -16,6 +16,13 @@ toc::[]

[id="rosa-q2-2025_{context}"]
=== Q2 2025
ifdef::openshift-rosa[]
* **AWS Trainium and Inferentia instance types now supported.** You can now use {AWS} Trainium and Inferentia instance types for your ROSA Classic clusters. For more information, see xref:../rosa_architecture/rosa_policy_service_definition/rosa-instance-types.adoc#rosa-sdpolicy-aws-instance-types[Red Hat OpenShift Service on AWS instance types].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **AWS Trainium and Inferentia instance types now supported.** You can now use {AWS} Trainium and Inferentia instance types for your ROSA Classic clusters. For more information, see xref:../rosa_architecture/rosa_policy_service_definition/rosa-instance-types.adoc#rosa-sdpolicy-aws-instance-types[Red Hat OpenShift Service on AWS instance types].
* **AWS Trainium and Inferentia instance types now supported.** You can now use {AWS} Trainium and Inferentia instance types for your {rosa-classic} clusters. For more information, see xref:../rosa_architecture/rosa_policy_service_definition/rosa-instance-types.adoc#rosa-sdpolicy-aws-instance-types[Red Hat OpenShift Service on AWS instance types].

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 24, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 24, 2025
Copy link

openshift-ci bot commented Jun 24, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Jun 24, 2025

@mletalie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bmcelvee
Copy link
Contributor

LGTM!

@bmcelvee bmcelvee merged commit 8fb206e into openshift:main Jun 24, 2025
2 checks passed
@bmcelvee
Copy link
Contributor

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@bmcelvee: new pull request created: #95162

In response to this:

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@bmcelvee: new pull request created: #95163

In response to this:

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 branch/enterprise-4.20 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants