Skip to content

bump AWS EC2LaunchV2 min version to 2.0.2107 #94609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mburke5678 merged 1 commit into from
Jun 23, 2025
Merged

bump AWS EC2LaunchV2 min version to 2.0.2107 #94609

mburke5678 merged 1 commit into from
Jun 23, 2025

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Jun 11, 2025 •
edited
Loading

openshift/windows-machine-config-operator#2809

QE review:

  • QE has approved this change.

DO NOT MERGE UNTIL WMCO 10.19.0 goes GA

@mburke5678 mburke5678 added this to the Planned for 4.19 GA milestone Jun 11, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 11, 2025
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2025
@mburke5678 mburke5678 force-pushed the wmco-ec2launch-version-bump branch from 21869bd to 3898b0c Compare June 11, 2025 16:16
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 11, 2025

🤖 Wed Jun 11 16:27:30 - Prow CI generated the docs preview:

https://94609--ocpdocs-pr.netlify.app/

@openshift-ci
Copy link

openshift-ci bot commented Jun 11, 2025

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jrvaldes
jrvaldes approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@jrvaldes jrvaldes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@weinliu
Copy link

weinliu commented Jun 13, 2025

/lgtm

@kalexand-rh kalexand-rh removed this from the Planned for 4.19 GA milestone Jun 13, 2025
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Jun 16, 2025

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@mburke5678 mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 23, 2025
@maxwelldb maxwelldb added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 23, 2025
@maxwelldb maxwelldb self-requested a review June 23, 2025 14:58
@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 23, 2025
@mburke5678 mburke5678 merged commit 4440d9c into openshift:main Jun 23, 2025
2 checks passed
@mburke5678 mburke5678 deleted the wmco-ec2launch-version-bump branch June 23, 2025 15:06
@mburke5678
Copy link
Contributor Author

mburke5678 commented Jun 23, 2025

/cherrypick enterprise-4.19

@mburke5678
Copy link
Contributor Author

mburke5678 commented Jun 23, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 23, 2025

@mburke5678: new pull request created: #95109

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 23, 2025

@mburke5678: new pull request created: #95110

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxwelldb maxwelldb maxwelldb approved these changes

+1 more reviewer

@jrvaldes jrvaldes jrvaldes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@weinliu weinliu

@jrvaldes jrvaldes

Labels

branch/enterprise-4.19 branch/enterprise-4.20 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mburke5678 @ocpdocs-previewbot @weinliu @bergerhoffer @openshift-cherrypick-robot @maxwelldb @jrvaldes @kalexand-rh