Skip to content

Update log6x-oc-explain.adoc #93677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: enterprise-4.15
Choose a base branch
from
Open

Update log6x-oc-explain.adoc #93677

wants to merge 1 commit into from

Conversation

amandverma
Copy link

@amandverma amandverma commented May 22, 2025 •
edited
Loading

Changed type information for lokistacks.loki.grafana.com.spec.size from integer to string

lokistacks.loki.grafana.com.spec.size should be defined using an string value

Version(s):

4.15

Issue:

https://issues.redhat.com/browse/OBSDOCS-1887

Link to docs preview:

https://93677--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-upgrading-to-6.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 22, 2025 •
edited
Loading

🤖 Thu May 22 18:01:56 - Prow CI generated the docs preview:

https://93677--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-upgrading-to-6.html

@amandverma
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 22, 2025
@jab-rh
Copy link
Contributor

jab-rh commented May 22, 2025

@amandverma, same comment as in: #93675 (review)

@jab-rh jab-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 22, 2025
@amandverma
Update log6x-oc-explain.adoc
e041fc4 
Improving grammar

Update log6x-oc-explain.adoc

Changed type information for lokistacks.loki.grafana.com.spec.size from integer to string
@amandverma
Copy link
Author

/label peer-review-needed

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 22, 2025

@amandverma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 22, 2025
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 22, 2025
skopacz1
skopacz1 approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skopacz1 skopacz1 added branch/enterprise-4.15 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 22, 2025
@skopacz1 skopacz1 added this to the Continuous Release milestone May 22, 2025
@anpingli
Copy link

LGTM

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skopacz1 skopacz1 skopacz1 approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.15 lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@amandverma @ocpdocs-previewbot @jab-rh @anpingli @openshift-bot @skopacz1