Skip to content

Conversation

hjaiswal12
Copy link
Contributor

@hjaiswal12 hjaiswal12 commented Mar 18, 2025

Updating the note for windows must-gather prerequisites

Version(s):

4.15+

Issue:

https://issues.redhat.com/browse/OCPBUGS-53231

Link to docs preview:

https://90413--ocpdocs-pr.netlify.app/openshift-dedicated/latest/support/gathering-cluster-data.html

QE review:

  • QE has approved this change.

Additional information:

Updating the note for windows must-gather prerequisites
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2025
Copy link

openshift-ci bot commented Mar 18, 2025

Hi @hjaiswal12. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hjaiswal12 hjaiswal12 changed the title Update about-must-gather.adoc Updating the note for windows must-gather prerequisites Mar 18, 2025
@xenolinux xenolinux added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 19, 2025
@hjaiswal12
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 19, 2025
@abhatt-rh abhatt-rh added this to the Continuous Release milestone Mar 19, 2025
Copy link
Contributor

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hjaiswal12 , just added a few nits.

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@@ -41,7 +41,8 @@ $ oc adm must-gather -- /usr/bin/gather_audit_logs
+
[NOTE]
====
Audit logs are not collected as part of the default set of information to reduce the size of the files.
. Audit logs are not collected as part of the default set of information to reduce the size of the files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per IBM Style for Ordered lists,

Use an ordered (numbered) list when the sequence is significant, for example, when you write procedures or rank items.

Suggested change
. Audit logs are not collected as part of the default set of information to reduce the size of the files.
* Audit logs are not collected as part of the default set of information to reduce the size of the files.

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 19, 2025
Copy link

openshift-ci bot commented Mar 21, 2025

@hjaiswal12: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hjaiswal12
Copy link
Contributor Author

@xenolinux can you please help to align QE for the same. TIA

@xenolinux
Copy link
Contributor

xenolinux commented Mar 21, 2025

@xenolinux can you please help to align QE for the same. TIA

You can ping on the OCP QE slack channel to align the QE

@hjaiswal12
Copy link
Contributor Author

Hi @max-cx , Can you help me to get it approved with QE.

Thank you in advance..!!

@hjaiswal12
Copy link
Contributor Author

I am unable to push new patch after squash(getting authentication error). Can anyone help me with squash and merge commits. Once done i will add label merge review needed. TIA

@hjaiswal12
Copy link
Contributor Author

Hi @xenolinux , I was facing issue while doing squash hence created the new one #91490 and added the merge level. Please review and do the needfull.

@hjaiswal12 hjaiswal12 changed the title Updating the note for windows must-gather prerequisites Updating the note for windows must-gather prerequisites [OCPBUGS-53231] Apr 2, 2025
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants