-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Updating the note for windows must-gather prerequisites [OCPBUGS-53231] #90413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updating the note for windows must-gather prerequisites
Hi @hjaiswal12. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hjaiswal12 , just added a few nits.
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done
@@ -41,7 +41,8 @@ $ oc adm must-gather -- /usr/bin/gather_audit_logs | |||
+ | |||
[NOTE] | |||
==== | |||
Audit logs are not collected as part of the default set of information to reduce the size of the files. | |||
. Audit logs are not collected as part of the default set of information to reduce the size of the files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per IBM Style for Ordered lists,
Use an ordered (numbered) list when the sequence is significant, for example, when you write procedures or rank items.
. Audit logs are not collected as part of the default set of information to reduce the size of the files. | |
* Audit logs are not collected as part of the default set of information to reduce the size of the files. |
Co-authored-by: Avani Bhatt <[email protected]>
@hjaiswal12: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@xenolinux can you please help to align QE for the same. TIA |
You can ping on the OCP QE slack channel to align the QE |
Hi @max-cx , Can you help me to get it approved with QE. Thank you in advance..!! |
I am unable to push new patch after squash(getting authentication error). Can anyone help me with squash and merge commits. Once done i will add label merge review needed. TIA |
Hi @xenolinux , I was facing issue while doing squash hence created the new one #91490 and added the merge level. Please review and do the needfull. |
The This is because your PR targets the If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Updating the note for windows must-gather prerequisites
Version(s):
4.15+
Issue:
https://issues.redhat.com/browse/OCPBUGS-53231
Link to docs preview:
https://90413--ocpdocs-pr.netlify.app/openshift-dedicated/latest/support/gathering-cluster-data.html
QE review:
Additional information: