Skip to content

Conversation

AedinC
Copy link
Contributor

@AedinC AedinC commented Jan 27, 2025

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-12593

Link to docs preview:

Peer review:

  • Peer reviewer has approved this change.

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2025
@AedinC AedinC changed the title OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. [WIP]OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. Jan 27, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch 2 times, most recently from 1ad928d to 005fba0 Compare January 28, 2025 15:25
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from 005fba0 to 5694f45 Compare January 28, 2025 16:06
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch 4 times, most recently from f6754f0 to db8df98 Compare February 6, 2025 11:20
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from db8df98 to 1fe8c6f Compare February 7, 2025 08:38
@AedinC
Copy link
Contributor Author

AedinC commented Feb 7, 2025

@andreadecorte Can you please review this when you get a chance? Many thanks.

@AedinC
Copy link
Contributor Author

AedinC commented Feb 11, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 11, 2025
@adellape adellape self-assigned this Feb 11, 2025
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 11, 2025
@adellape adellape added this to the Planned for 4.18 GA milestone Feb 11, 2025
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 11, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from 1fe8c6f to 6f61720 Compare February 12, 2025 11:54
@AedinC AedinC changed the title [WIP]OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. Feb 12, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@kalexand-rh kalexand-rh removed this from the OCP 4.18 GA milestone Feb 24, 2025
@kalexand-rh kalexand-rh added this to the Continuous Release milestone Feb 24, 2025
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2025
@AedinC
Copy link
Contributor Author

AedinC commented May 26, 2025

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from 6f61720 to 612c1c1 Compare June 18, 2025 09:41
@andreadecorte
Copy link

@AedinC actually the commands here are still based the instructions for the public preview, the GA will have a few changes in the UX, so we can review when we start approaching to the production release. Overall I don't expect major changes in any case, thanks!

@andreadecorte
Copy link

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2025
@AedinC
Copy link
Contributor Author

AedinC commented Jun 24, 2025

@AedinC actually the commands here are still based the instructions for the public preview, the GA will have a few changes in the UX, so we can review when we start approaching to the production release. Overall I don't expect major changes in any case, thanks!

Thanks @andreadecorte. I will be on leave from July 7th to August 5th but will have time to implement the changes before feature release when I come back.

@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch 3 times, most recently from b513f47 to a0566ae Compare August 11, 2025 12:31
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from a0566ae to a0bc2b5 Compare September 1, 2025 12:32
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from a0bc2b5 to 534629b Compare September 1, 2025 12:47
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from 534629b to d1646f8 Compare September 1, 2025 13:01
Copy link

openshift-ci bot commented Sep 1, 2025

@AedinC: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@AedinC
Copy link
Contributor Author

AedinC commented Sep 3, 2025

Hi @andreadecorte I revised the docs based on GA feature design. Can you please advise if any thing needs to be changed or added? Thanks.

@andreadecorte
Copy link

hi Aedin, I think changes look good, thanks! I also ask @BraeTroutman to take a look, he is now leading the feature so you can coordinate with him for the target release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants