Skip to content

Conversation

suleymanakbas91
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2024
@openshift-ci openshift-ci bot requested review from jerpeter1 and qJkee December 19, 2024 11:38
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
@suleymanakbas91 suleymanakbas91 changed the title chore: bump golang.org/x/net to v0.33.0 OCPBUGS-46667: Bump golang.org/x/net to v0.33.0 Dec 19, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 19, 2024
@openshift-ci-robot
Copy link

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-46667, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mmakwana30

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 19, 2024
@openshift-ci openshift-ci bot requested a review from mmakwana30 December 19, 2024 11:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.61%. Comparing base (0bfc846) to head (76dab98).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   69.32%   69.61%   +0.29%     
==========================================
  Files          50       50              
  Lines        3443     3443              
==========================================
+ Hits         2387     2397      +10     
+ Misses        868      861       -7     
+ Partials      188      185       -3     

see 3 files with indirect coverage changes

@qJkee
Copy link
Contributor

qJkee commented Dec 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0bfc846 and 2 for PR HEAD 76dab98 in total

@suleymanakbas91
Copy link
Contributor Author

/override e2e-aws-hypershift

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@suleymanakbas91: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-aws-hypershift

Only the following failed contexts/checkruns were expected:

  • ci/prow/ci-index-lvm-operator-bundle
  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-hypershift
  • ci/prow/e2e-aws-single-node
  • ci/prow/images
  • ci/prow/precommit-check
  • ci/prow/snyk-code
  • ci/prow/snyk-deps
  • ci/prow/unit-test
  • pull-ci-openshift-lvm-operator-main-ci-index-lvm-operator-bundle
  • pull-ci-openshift-lvm-operator-main-e2e-aws
  • pull-ci-openshift-lvm-operator-main-e2e-aws-hypershift
  • pull-ci-openshift-lvm-operator-main-e2e-aws-single-node
  • pull-ci-openshift-lvm-operator-main-images
  • pull-ci-openshift-lvm-operator-main-precommit-check
  • pull-ci-openshift-lvm-operator-main-snyk-code
  • pull-ci-openshift-lvm-operator-main-snyk-deps
  • pull-ci-openshift-lvm-operator-main-unit-test
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-aws-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@suleymanakbas91
Copy link
Contributor Author

/override ci/prow/e2e-aws-hypershift

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@suleymanakbas91: Overrode contexts on behalf of suleymanakbas91: ci/prow/e2e-aws-hypershift

In response to this:

/override ci/prow/e2e-aws-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@suleymanakbas91
Copy link
Contributor Author

/cherry-pick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14 release-4.13 release-4.12

@openshift-cherrypick-robot

@suleymanakbas91: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14 release-4.13 release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@suleymanakbas91 suleymanakbas91 merged commit d4f8772 into openshift:main Dec 19, 2024
10 of 11 checks passed
@suleymanakbas91 suleymanakbas91 deleted the bump branch December 19, 2024 15:15
@openshift-ci-robot
Copy link

@suleymanakbas91: Jira Issue OCPBUGS-46667: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-46667 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@suleymanakbas91: new pull request created: #819

In response to this:

/cherry-pick release-4.18 release-4.17 release-4.16 release-4.15 release-4.14 release-4.13 release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants