Skip to content

WIP pkg/server: get rules/alerts from thanos#5881

Closed
s-urbaniak wants to merge 1 commit intoopenshift:masterfrom
s-urbaniak:show-all-alerts
Closed

WIP pkg/server: get rules/alerts from thanos#5881
s-urbaniak wants to merge 1 commit intoopenshift:masterfrom
s-urbaniak:show-all-alerts

Conversation

@s-urbaniak
Copy link
Copy Markdown
Contributor

This enables user workload alerting rules to be shown in the admin perspective.
As discussed in the arch call it is favorable to implement some filtering knobs first in the UI.
Additionally this requires thanos-io/thanos#2834 to be pulled in downstream first.

/cc @openshift/openshift-team-monitoring

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2020
@s-urbaniak
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. component/backend Related to backend labels Jul 2, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: s-urbaniak
To complete the pull request process, please assign spadgett
You can assign the PR to them by writing /assign @spadgett in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Copy Markdown
Contributor

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@s-urbaniak: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console ae840a9 link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Copy Markdown
Contributor

Superseded by #5941
/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@simonpasquier: Closed this PR.

Details

In response to this:

Superseded by #5941
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/backend Related to backend do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants