WIP pkg/server: get rules/alerts from thanos#5881
WIP pkg/server: get rules/alerts from thanos#5881s-urbaniak wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
/hold |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: s-urbaniak The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
@s-urbaniak: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Superseded by #5941 |
|
@simonpasquier: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This enables user workload alerting rules to be shown in the admin perspective.
As discussed in the arch call it is favorable to implement some filtering knobs first in the UI.
Additionally this requires thanos-io/thanos#2834 to be pulled in downstream first.
/cc @openshift/openshift-team-monitoring