-
Notifications
You must be signed in to change notification settings - Fork 164
LOG-2259: Vector: Add Route transform for application routing only once #1350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -96,6 +96,7 @@ func SourcesToInputs(spec *logging.ClusterLogForwarderSpec, o generator.Options) | |||
el = append(el, r) | |||
} | |||
userDefined := spec.InputMap() | |||
RouteMap := map[string]string{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. should be routeMap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
@vimalk78 I have one nit. I defer to you if you want to fix it in a subsequent PR |
@vimalk78: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, vimalk78 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LOG-2259: Vector: Add Route transform for application routing only once
Description
The Route transform was added for each input with user defined inputs. Just one Route transform is sufficient with a map for each user defined input.
/cc @jcantrill
/assign
/cherry-pick
Links